Skip to content

fix profile popup while tabbing (bug #1949) #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syu213 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix profile popup while tabbing (bug #1949) #5145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/shared/src/components/profile/ProfileTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ export function ProfileTooltip({
content: !isLoading && data ? <UserEntityCard user={data} /> : null,
plugins:
onTooltipMouseEnter || onTooltipMouseLeave ? [hoverPlugin] : undefined,
// Remove focus from trigger to prevent keyboard accessibility issues
trigger: 'mouseenter',
...tooltip,
onShow: (instance) => {
if (id !== userId) {
Expand Down
42 changes: 34 additions & 8 deletions packages/shared/src/components/profile/UserShortInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ import { formatCoresCurrency } from '../../lib/utils';
import { Image } from '../image/Image';
import { ButtonVariant } from '../buttons/Button';

const getProfileUrl = (username: string): string => {
return `https://app.daily.dev/${username}`;
};

type PropsOf<Tag> = Tag extends keyof JSX.IntrinsicElements
? JSX.IntrinsicElements[Tag]
: Tag extends React.ComponentType<infer Props>
Expand Down Expand Up @@ -97,15 +101,37 @@ const UserShortInfoComponent = <Tag extends React.ElementType>(
visible: disableTooltip ? false : undefined,
};

const handleKeyDown = (event: React.KeyboardEvent) => {
if ((event.key === 'Enter' || event.key === ' ') && !onClick) {
event.preventDefault();
// Navigate to full profile page instead of showing popup
window.open(getProfileUrl(username), '_blank');
}
};

// Add proper keyboard accessibility
const accessibilityProps =
tag === 'a'
? {}
: {
tabIndex: 0,
role: 'button' as const,
'aria-label': `View ${name}'s profile`,
onKeyDown: handleKeyDown,
};

const elementProps = {
ref,
...props,
className: classNames(
'flex flex-row',
className.container ?? defaultClassName.container,
),
...accessibilityProps,
};

return (
<Element
ref={ref}
{...props}
className={classNames(
'flex flex-row',
className.container ?? defaultClassName.container,
)}
>
<Element {...elementProps}>
<ProfileTooltip
userId={user?.id}
tooltip={tooltipProps}
Expand Down