Support async agents (#90)

[cboos]

Summary

Adds rendering support for Claude Code's async-agent flow (issue #90):
Task tool_use with run_in_background=True, TaskOutput polling
tool, and <task-notification> user entries injected when the agent
completes. The agent's answer surfaces at the spawn site (folded
under the spawning Task tool_result) so the reader sees it where they
expect, not buried at the tail of the relocated sidechain.

Phases

1. Typed models + parsers (d575c75) — TaskOutputInput (Pydantic),
   TaskOutputResult, TaskNotificationMessage, TaskNotificationUsage
   (dataclasses); task_notification_factory parses
   <task-notification> user content; parse_taskoutput_output parses
   the <retrieval_status>/<task_id>/<task_type>/<status>/<output>
   poll body.
2. HTML + Markdown rendering (8b21baf) — 🔍 TaskOutput #<id>
   poll cards, 🔄 Async result · *summary* notification cards, and
   the [async] hint badge on the Task tool_use title when
   run_in_background=True.
3. Spawn-fold + notification dedup:
   • 483bd09 — flag notifications whose result text duplicates the
     last sub-assistant; render them as backlink stubs.
   • 3396601 — place task_notification at hierarchy level 3 so
     surrounding messages don't accidentally nest under it.
   • 7f6ff89 — fold the agent's final answer onto
     TaskOutput.async_final_answer and drop the duplicate
     sub-assistant from the sidechain tree.
   • 4fd194e — stop the .tool_result .collapsible-code negative
     margin from yanking the async-answer fold over its label.
4. Tests + fixture (7c60c86) — synthetic test/test_data/async_agents/
   fixture sliced from the canonical clmail-monk transcript;
   test/test_async_agents.py (32 tests) covers parser positive/edge
   cases, fixture loading, factory dispatch, the rendering pipeline,
   and detail-level invariants. HTML + Markdown snapshots locked in.
5. Detail-level handling:
   • aeb2e1b (Plan A) — source the spawn-fold from the notification's
     result_text instead of from the (now-stripped) sidechain
     assistant, so the fold survives at --detail low.
   • 1f072de — drop duplicate-flagged notifications at LOW
     (post-link pass; the spawn-fold already shows the answer, the
     standalone card is pure redundancy at this terse level).
   • e1ecbd5 — register TaskNotificationMessage in
     CSS_CLASS_REGISTRY (["user", "task_notification"]) so the
     runtime "User" filter toggle keeps the card visible (without
     it the only class was task_notification, matching no toolbar
     type and permanently flagged filtered-hidden).
   • 955a1e9 — re-run _identify_message_pairs after the LOW drop
     pass so the Task tool_use ↔ tool_result CSS pairing classes
     and the Markdown's paired-body rendering both stay correct.
6. Lint cleanup (6c4e953) — drop four unused
   # type: ignore[no-untyped-def] test-helper comments flagged by
   uv run ty check.

Detail-level matrix (canonical clmail-monk fixture, 4 async tasks)

level	spawn-folds	notification cards	answer visible
full	4	4 (full metadata)	yes (folded)
high	4	4 (full metadata)	yes (folded)
low	4	0 (dropped)	yes (folded)
minimal	0	4 (with body)	yes (notification body)
user-only	0	4 (with body)	yes (notification body)

Answer is visible exactly once at every detail level.

Test plan

• uv run pytest -n auto -m "not (tui or browser)" — 1123 passed, 7 skipped
• uv run pyright — 0 errors, 0 warnings
• uv run ty check — all checks passed
• uv run ruff check — all checks passed
• HTML + Markdown snapshot suites refreshed
• Manual verification on canonical clmail-monk fixture at every detail level

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Async background tasks: polling, TaskOutput parsing, task-notification cards (id/status/summary/result/usage/transcript), collapsible bodies, and backlinking with folded async final answers into spawning task results

• Bug Fixes

  • Duplicate-result detection/suppression to avoid double-rendering and remove redundant sub-assistant nodes

• Documentation

  • Added docs for async-agent flow, message types, folding, and detail-level visibility

• Tests

  • New integration and snapshot tests covering parsing, folding, rendering, and detail-level behavior

• Style

  • UI styles and status indicators for async task cards

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds async-agent support: parse <task-notification> user entries and TaskOutput polling results, introduce models and factories, register tool dispatch, stitch and fold notifications into spawning Task tool results during rendering, add HTML/Markdown formatters and CSS, and include end-to-end tests and fixtures.

Changes

Cohort / File(s)	Summary
Models claude_code_log/models.py	Adds TaskNotificationUsage, TaskNotificationMessage, TaskOutputInput, TaskOutputResult; adds TaskOutput.async_final_answer.
User & Parsing Factories claude_code_log/factories/task_notification_factory.py, claude_code_log/factories/user_factory.py	New task-notification factory with has_task_notification and create_task_notification_message; user factory dispatches parsed TaskNotificationMessage early and updates UserMessageContent union.
Tool Factory claude_code_log/factories/tool_factory.py	Registers TaskOutput input parsing and parse_taskoutput_output returning TaskOutputResult (handles truncation/output file detection); updates output parser registry.
Renderer Core claude_code_log/renderer.py	Adds _link_async_notifications to link notifications to spawning Task/tool_result (via agentId or fallback), fold result_text into TaskOutput.async_final_answer, mark duplicates, remove duplicate sidechain assistant nodes, and set task_notification hierarchy level.
HTML Formatting & CSS claude_code_log/html/async_formatter.py, claude_code_log/html/renderer.py, claude_code_log/html/tool_formatters.py, claude_code_log/html/utils.py, claude_code_log/html/templates/components/teammate_styles.css, claude_code_log/html/templates/components/timeline.html	Adds async formatter module and renderer hooks for TaskOutput/TaskNotificationMessage; updates tool formatter to render folded async answers; maps CSS classes and timeline grouping; adds backlink and async hint styling.
Markdown Rendering claude_code_log/markdown/renderer.py	Adds markdown formatters/titles for TaskOutputInput, TaskOutputResult, and TaskNotificationMessage; renders stub + folded async final answer and applies LOW-detail suppression for duplicate notifications.
Tests & Fixtures test/test_async_agents.py, test/test_snapshot_html.py, test/test_snapshot_markdown.py, test/__snapshots__/test_snapshot_markdown.ambr, test/test_data/async_agents/...	Adds unit/integration tests for detection/parsing/dispatch, end-to-end linking/folding/dedup behavior, HTML/Markdown snapshots, and JSONL fixtures including subagent sidechain.
Docs & Worknotes work/async-agents.md, dev-docs/agents.md, dev-docs/messages.md, dev-docs/teammates.md, dev-docs/FOLD_STATE_DIAGRAM.md, test/test_data/async_agents/README.md	Adds design and usage docs describing formats, stitching/folding rules, hierarchy mapping, detail-level behaviors, and fixture expectations.
Templates claude_code_log/html/templates/components/timeline.html	Adds task-notification timeline group and ensures proper grouping/order in timeline rendering.

Sequence Diagram

sequenceDiagram
    participant User as User
    participant UserFactory as UserFactory
    participant TaskNotificationFactory as TaskNotificationFactory
    participant Renderer as Renderer
    participant ToolFactory as ToolFactory
    participant HtmlFormatter as HtmlFormatter

    User->>UserFactory: create_user_message(text)
    UserFactory->>TaskNotificationFactory: has_task_notification(text)
    alt notification found
        UserFactory->>TaskNotificationFactory: create_task_notification_message(meta, text)
        TaskNotificationFactory-->>UserFactory: TaskNotificationMessage
        UserFactory-->>Renderer: add TaskNotificationMessage
    else regular user text
        UserFactory-->>Renderer: add TextUserMessage
    end

    Renderer->>ToolFactory: parse tool results (Task / TaskOutput)
    ToolFactory-->>Renderer: TaskOutputInput / TaskOutputResult
    Renderer->>Renderer: _link_async_notifications()
    Note right of Renderer: extract agentId (metadata or regex)\nlink notification -> spawning tool_result\nfold result_text -> TaskOutput.async_final_answer\nmark result_is_duplicate / prune duplicate sidechain

    Renderer->>HtmlFormatter: format_task_notification_content(notification)
    HtmlFormatter-->>Renderer: html_string
    Renderer-->>User: final rendered transcript

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

• Detail levels and compact rendering of conversations #96 — renderer-level folding/ghosting and detail-aware behavior that this PR builds on.
• Fix Parallel Sidechain Rendering #54 — agentId propagation and sidechain reordering used by async-task linking.
• Polish User Messages #60 — message-hierarchy nesting adjustments intersecting with task_notification level changes.

Suggested labels

enhancement

Suggested reviewers

• daaain

Poem

🐰 Hops to parse each async note with cheer,

Task IDs and summaries now appear.
Folded answers stitched where spawns began,
Duplicates tucked neatly from the clan.
A rabbit hums — async tasks are here!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 61.22% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'Support async agents (#90)' directly reflects the main objective of the changeset, which comprehensively adds parsing, rendering, and session-level stitching for async-agent workflows.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev/async-agents

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (1)

claude_code_log/html/templates/components/teammate_styles.css (1)

273-277: Both .task-update-card and .task-notification-card use --cc-blue.

Just a note: the new .task-notification-card shares the cyan/blue palette with .task-update-card (line 324–328). They likely don't co-appear in most transcripts, so the visual scan from cyan (task-output-card) → blue (task-notification-card) still works — but if you ever want to disambiguate at a glance, picking a distinct token (e.g. --cc-purple or --cc-pink) for the notification card would make the spawn → poll → notification chain three distinct colors instead of two.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@claude_code_log/html/templates/components/teammate_styles.css` around lines
273 - 277, The .teammate-tool-card.task-notification-card currently reuses
--cc-blue (same as .task-update-card); change it to a distinct token (e.g.
--cc-purple or --cc-pink) to improve visual disambiguation: update the CSS block
for .teammate-tool-card.task-notification-card to set --cc-color:
var(--cc-purple) (or var(--cc-pink)) and keep border-left: 4px solid
var(--cc-color); if --cc-purple/--cc-pink don't exist yet, add the variable to
the global/root color definitions so the new token resolves.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@claude_code_log/html/utils.py`:
- Around line 71-76: Add support for the "task_notification" message type in
timeline rendering: add a new entry for "task_notification" in messageTypeGroups
to define its display styling, and update the message-type detection logic to
explicitly check for "task_notification" (using the same pattern as the existing
teammate check) before the generic .find() that classifies messages — this
ensures messages whose CSS_CLASS_REGISTRY entry TaskNotificationMessage =
["user","task_notification"] are detected as task_notification rather than
falling back to the user type.
- Line 76: The registry entry TaskNotificationMessage currently uses an
underscore for the CSS modifier; update the modifier string in the registry from
"task_notification" to "task-notification" (i.e., change
TaskNotificationMessage: ["user", "task_notification"] to use
"task-notification") so it matches the CSS rules in teammate_styles.css and the
rest of the modifier naming convention; do not change the message type
identifiers in models.py or renderer.py (they remain "task_notification").

In `@claude_code_log/renderer.py`:
- Around line 2163-2166: The code currently sets
notification.result_is_duplicate whenever spawn_target_kept is true, which can
hide the final answer when content.output wasn't parsed as a TaskOutput; change
the logic so that you only set notification.result_is_duplicate = True when
spawn_target_kept is true AND isinstance(content.output, TaskOutput) (and still
assign content.output.async_final_answer = notification.result_text in that same
branch); reference content.output, TaskOutput, notification.result_is_duplicate,
spawn_target_kept and _async_agent_id_from_tool_result() to locate the relevant
conditional and update it accordingly.
- Around line 835-837: The LOW-detail duplicate-drop step mutates
message_index/parent_message_index after session_nav was built in
generate_template_messages, causing misaligned indices; either call
_drop_duplicate_notifications_at_low(ctx) before prepare_session_navigation()
inside generate_template_messages, or after the drop explicitly rebuild
session_nav (the same structure prepare_session_navigation produces) so
session_nav reflects the updated message_index/parent_message_index; update the
codepath that handles DetailLevel.LOW (the if detail == DetailLevel.LOW block)
to perform one of these fixes and ensure downstream uses of session_nav use the
rebuilt version.

---

Nitpick comments:
In `@claude_code_log/html/templates/components/teammate_styles.css`:
- Around line 273-277: The .teammate-tool-card.task-notification-card currently
reuses --cc-blue (same as .task-update-card); change it to a distinct token
(e.g. --cc-purple or --cc-pink) to improve visual disambiguation: update the CSS
block for .teammate-tool-card.task-notification-card to set --cc-color:
var(--cc-purple) (or var(--cc-pink)) and keep border-left: 4px solid
var(--cc-color); if --cc-purple/--cc-pink don't exist yet, add the variable to
the global/root color definitions so the new token resolves.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fac7496e-5c54-4d32-9495-017177c236ed

📥 Commits

Reviewing files that changed from the base of the PR and between 9b9d3c5 and 6c4e953.

📒 Files selected for processing (21)

• claude_code_log/factories/task_notification_factory.py
• claude_code_log/factories/tool_factory.py
• claude_code_log/factories/user_factory.py
• claude_code_log/html/async_formatter.py
• claude_code_log/html/renderer.py
• claude_code_log/html/templates/components/teammate_styles.css
• claude_code_log/html/tool_formatters.py
• claude_code_log/html/utils.py
• claude_code_log/markdown/renderer.py
• claude_code_log/models.py
• claude_code_log/renderer.py
• dev-docs/FOLD_STATE_DIAGRAM.md
• test/__snapshots__/test_snapshot_html.ambr
• test/__snapshots__/test_snapshot_markdown.ambr
• test/test_async_agents.py
• test/test_data/async_agents/README.md
• test/test_data/async_agents/eb000000-0000-4000-8000-000000000001.jsonl
• test/test_data/async_agents/eb000000-0000-4000-8000-000000000001/subagents/agent-cccc333.jsonl
• test/test_snapshot_html.py
• test/test_snapshot_markdown.py
• work/async-agents.md

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

dev-docs/messages.md (1)

365-366: Clarify the note reference for better readability.

Both rows reference *(see note)* but the actual note explaining the TaskOutput vs TaskOutputResult distinction appears 10 lines later (lines 375-382). This vague reference may cause readers to search for the note.

Consider making the reference more specific:

• Change to *(see note below)*
• Or add an anchor/reference: *(see § TaskOutput vs TaskOutputResult)*
• Or place the note immediately after this table

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@dev-docs/messages.md` around lines 365 - 366, Update the ambiguous note
reference for the table rows that show TaskOutput and TaskOutputResult: replace
`*(see note)*` with a clearer reference such as `*(see note below)*` or `*(see §
TaskOutput vs TaskOutputResult)*`, and either move the explanatory note for
TaskOutput/TaskOutputResult to immediately after the table or add a named
anchor/heading "TaskOutput vs TaskOutputResult" so readers can jump directly to
the explanation; ensure both table cells referencing TaskOutput and
TaskOutputResult use the same clarified phrasing.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@claude_code_log/renderer.py`:
- Around line 838-847: After LOW-detail reindexing in
_reindex_filtered_context() the TemplateMessage.ancestry and stored backlink
fields (SessionHeaderMessage.parent_message_index and
TaskNotificationMessage.spawning_task_message_index) are left with old indices;
update those to the new indices or rebuild the hierarchy to avoid broken d-{...}
anchors—either (1) remap TemplateMessage.ancestry and the two stored backlink
fields using the same old->new index map produced by _reindex_filtered_context()
before you call prepare_session_navigation(session_nav), or (2) call
_build_message_hierarchy()/_build_message_tree() again after the drop so
ancestry and parent/spawning indices are freshly computed; ensure this change is
applied where session_nav is rebuilt (the prepare_session_navigation call) and
also at the other indicated locations (lines flagged for the same issue).

In `@dev-docs/agents.md`:
- Around line 147-149: Update the docs to reference the correct registry and CSS
modifier: replace the incorrect `CSS_CLASS_REGISTRY` symbol with
`MESSAGE_TYPE_TO_CSS_CLASSES` and change the CSS modifier `task_notification` to
`task-notification` so the sentence reads that `MESSAGE_TYPE_TO_CSS_CLASSES`
maps `TaskNotificationMessage` to `["user", "task-notification"]`, ensuring
readers are pointed at the right symbol and class name.

---

Nitpick comments:
In `@dev-docs/messages.md`:
- Around line 365-366: Update the ambiguous note reference for the table rows
that show TaskOutput and TaskOutputResult: replace `*(see note)*` with a clearer
reference such as `*(see note below)*` or `*(see § TaskOutput vs
TaskOutputResult)*`, and either move the explanatory note for
TaskOutput/TaskOutputResult to immediately after the table or add a named
anchor/heading "TaskOutput vs TaskOutputResult" so readers can jump directly to
the explanation; ensure both table cells referencing TaskOutput and
TaskOutputResult use the same clarified phrasing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c8aabd3-52b9-4541-925f-3877a1019ede

📥 Commits

Reviewing files that changed from the base of the PR and between 6c4e953 and 8501d5e.

📒 Files selected for processing (7)

• claude_code_log/html/templates/components/timeline.html
• claude_code_log/html/utils.py
• claude_code_log/renderer.py
• dev-docs/agents.md
• dev-docs/messages.md
• dev-docs/teammates.md
• test/__snapshots__/test_snapshot_html.ambr

🚧 Files skipped from review as they are similar to previous changes (1)

• claude_code_log/html/utils.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Fix the referenced registry name and CSS modifier.

html/utils.py exposes MESSAGE_TYPE_TO_CSS_CLASSES, and the notification class is task-notification in the actual mapping. As written, this points readers at the wrong symbol and the wrong class name.

📝 Suggested doc fix

-- `html/utils.py::CSS_CLASS_REGISTRY` —
--   `TaskNotificationMessage: ["user", "task_notification"]` so the
+- `html/utils.py::MESSAGE_TYPE_TO_CSS_CLASSES` —
+-   `TaskNotificationMessage: ["user", "task-notification"]` so the

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- `html/utils.py::CSS_CLASS_REGISTRY` —
	`TaskNotificationMessage: ["user", "task_notification"]` so the
	runtime "User" filter toggle keeps the card visible.
	- `html/utils.py::MESSAGE_TYPE_TO_CSS_CLASSES` —
	`TaskNotificationMessage: ["user", "task-notification"]` so the
	runtime "User" filter toggle keeps the card visible.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@dev-docs/agents.md` around lines 147 - 149, Update the docs to reference the
correct registry and CSS modifier: replace the incorrect `CSS_CLASS_REGISTRY`
symbol with `MESSAGE_TYPE_TO_CSS_CLASSES` and change the CSS modifier
`task_notification` to `task-notification` so the sentence reads that
`MESSAGE_TYPE_TO_CSS_CLASSES` maps `TaskNotificationMessage` to `["user",
"task-notification"]`, ensuring readers are pointed at the right symbol and
class name.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

claude_code_log/markdown/renderer.py (1)

891-894: Optional: make the Spawn backlink an actual link in Markdown.

The HTML version emits <a href="#msg-d-N">↱ Task</a>, but here the line is a static #d-N label that won't navigate in Markdown viewers. If anchors d-N (or whatever the Markdown side uses) are reachable, consider turning it into [↱ Task #d-N](#d-N) so readers can jump back to the spawn.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@claude_code_log/markdown/renderer.py` around lines 891 - 894, Replace the
static label written by lines.append when content.spawning_task_message_index is
set with a Markdown link that points to the same anchor used by the HTML output;
i.e., build the string from content.spawning_task_message_index and emit
something like "[↱ Task `#d-`{index}](`#msg-d-`{index})" instead of the current "-
**Spawn:** ↱ Task `#d-{index}`" so Markdown viewers can navigate back to the
spawn; update the lines.append call that references
content.spawning_task_message_index accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@claude_code_log/html/renderer.py`:
- Around line 779-801: The docstring for title_TaskNotificationMessage promises
a "•" separator but the rendered title lacks it; update the function
title_TaskNotificationMessage to include the bullet (e.g., "🔄 Async result • ")
before the summary or task_id when building the return strings to match the
docstring and the markdown renderer (or alternatively update the docstring to
remove the bullet); locate and modify the branches that return the summary (the
string built with "<span class='tool-summary'>..."), the task_id branch (the
f"🔄 Async result <code>..."), and the default return to ensure consistent use
of the "•" separator.

---

Nitpick comments:
In `@claude_code_log/markdown/renderer.py`:
- Around line 891-894: Replace the static label written by lines.append when
content.spawning_task_message_index is set with a Markdown link that points to
the same anchor used by the HTML output; i.e., build the string from
content.spawning_task_message_index and emit something like "[↱ Task
`#d-`{index}](`#msg-d-`{index})" instead of the current "- **Spawn:** ↱ Task
`#d-{index}`" so Markdown viewers can navigate back to the spawn; update the
lines.append call that references content.spawning_task_message_index
accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc4e598b-f34c-459a-8752-0593000c6d6b

📥 Commits

Reviewing files that changed from the base of the PR and between 8501d5e and ee263ed.

📒 Files selected for processing (6)

• claude_code_log/html/renderer.py
• claude_code_log/markdown/renderer.py
• claude_code_log/renderer.py
• dev-docs/agents.md
• test/__snapshots__/test_snapshot_html.ambr
• test/test_async_agents.py

🚧 Files skipped from review as they are similar to previous changes (2)

• test/test_async_agents.py
• claude_code_log/renderer.py

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Docstring promises • separator the code doesn't emit.

The docstring says the title is 🔄 Async result • <summary>, but the rendered output is 🔄 Async result <span class='tool-summary'>...</span> — no bullet. The Markdown counterpart (title_TaskNotificationMessage in markdown/renderer.py) actually emits ·. Either drop the bullet from the docstring or add one to the rendered output for parity.

✏️ Suggested code change to match the docstring

         if content.summary:
             return (
-                "🔄 Async result "
+                "🔄 Async result • "
                 f"<span class='tool-summary'>{escape_html(content.summary)}</span>"
             )

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	def title_TaskNotificationMessage(
	self, content: TaskNotificationMessage, _: TemplateMessage
	) -> str:
	"""Title → '🔄 Async result • <summary>' for an async-agent
	completion notification (issue #90). The summary is the most
	useful at-a-glance hint; the rest of the metadata renders in
	the body card.
	Empty at ``DetailLevel.LOW`` for duplicate-flagged
	notifications — pairs with ``format_TaskNotificationMessage``
	to "ghost" the card while keeping the message in
	``ctx.messages``.
	"""
	if self.detail == DetailLevel.LOW and content.result_is_duplicate:
	return ""
	if content.summary:
	return (
	"🔄 Async result "
	f"<span class='tool-summary'>{escape_html(content.summary)}</span>"
	)
	if content.task_id:
	return f"🔄 Async result <code>#{escape_html(content.task_id)}</code>"
	return "🔄 Async result"
	def title_TaskNotificationMessage(
	self, content: TaskNotificationMessage, _: TemplateMessage
	) -> str:
	"""Title → '🔄 Async result • <summary>' for an async-agent
	completion notification (issue `#90`). The summary is the most
	useful at-a-glance hint; the rest of the metadata renders in
	the body card.
	Empty at ``DetailLevel.LOW`` for duplicate-flagged
	notifications — pairs with ``format_TaskNotificationMessage``
	to "ghost" the card while keeping the message in
	``ctx.messages``.
	"""
	if self.detail == DetailLevel.LOW and content.result_is_duplicate:
	return ""
	if content.summary:
	return (
	"🔄 Async result • "
	f"<span class='tool-summary'>{escape_html(content.summary)}</span>"
	)
	if content.task_id:
	return f"🔄 Async result <code>#{escape_html(content.task_id)}</code>"
	return "🔄 Async result"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@claude_code_log/html/renderer.py` around lines 779 - 801, The docstring for
title_TaskNotificationMessage promises a "•" separator but the rendered title
lacks it; update the function title_TaskNotificationMessage to include the
bullet (e.g., "🔄 Async result • ") before the summary or task_id when building
the return strings to match the docstring and the markdown renderer (or
alternatively update the docstring to remove the bullet); locate and modify the
branches that return the summary (the string built with "<span
class='tool-summary'>..."), the task_id branch (the f"🔄 Async result
<code>..."), and the default return to ensure consistent use of the "•"
separator.

[cboos]

It's good enough in HTML, no need for "•" separator, and we can see that as the comment trying to be clear rather than literal. And we have to stop somewhere ;-)

[coderabbitai]

@cboos Fair point — the tool-summary span styling already provides enough visual contrast to separate the label from the summary text, as the screenshot confirms. Closing this one out.

( ˘•ω•˘ )

---

🧠 Learnings used

Learnt from: cboos
Repo: daaain/claude-code-log PR: 0
File: :0-0
Timestamp: 2026-04-19T19:57:27.884Z
Learning: In `claude_code_log`, `SessionHeaderMessage` summaries (Claude-authored session titles) are intentionally preserved in `--detail user-only` output. They serve as structural/navigational scaffolding that helps downstream agents identify topic boundaries (e.g., building a `requirements.md` from a transcript). Do not flag them as assistant-authored content that should be excluded.

---

Learnt from: CR
Repo: daaain/claude-code-log PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-12T20:52:29.636Z
Learning: Applies to claude_code_log/renderer.py : When adding new message types or modifying CSS class generation in Python renderer, update the timeline's message type detection logic in `claude_code_log/templates/components/timeline.html` to maintain feature parity

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@claude_code_log/factories/task_notification_factory.py`:
- Around line 114-122: The current code runs _FIELD_RE.finditer over the entire
body so any tags inside the <result> or <usage> sections can clobber real
metadata; change the parsing order to first locate result_match =
_RESULT_RE.search(body) and usage_match = _USAGE_RE.search(body), compute a
cutoff index = min(start of result_match, start of usage_match) if present (or
len(body) otherwise), then run _FIELD_RE.finditer on body[:cutoff] to populate
fields; continue to extract result_text from result_match and usage via
_parse_usage(usage_match.group("body")) as before. Ensure you reference fields,
_FIELD_RE, result_match/_RESULT_RE, usage_match/_USAGE_RE and _parse_usage when
making the change.

In `@claude_code_log/renderer.py`:
- Around line 2293-2298: The early check that skips entries when
content.tool_name is not in ("Task", "Agent") prevents
`_async_agent_id_from_tool_result(content)` from recovering async agent IDs and
causes orphaned notifications; remove or move that `tool_name` filter so you
always call `_async_agent_id_from_tool_result(content)` for any
`ToolResultMessage` and only skip when that call returns None (or after applying
the same fallback used by `_relocate_subagent_blocks()`); ensure you still only
process instances of `ToolResultMessage` and preserve existing logic that uses
the recovered `agent_id` to fold notifications back into the spawn.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1780624b-f07f-466c-8951-8d3dcf02f1da

📥 Commits

Reviewing files that changed from the base of the PR and between ee263ed and e9f5ead.

📒 Files selected for processing (25)

• claude_code_log/factories/task_notification_factory.py
• claude_code_log/factories/tool_factory.py
• claude_code_log/factories/user_factory.py
• claude_code_log/html/async_formatter.py
• claude_code_log/html/renderer.py
• claude_code_log/html/templates/components/teammate_styles.css
• claude_code_log/html/templates/components/timeline.html
• claude_code_log/html/tool_formatters.py
• claude_code_log/html/utils.py
• claude_code_log/markdown/renderer.py
• claude_code_log/models.py
• claude_code_log/renderer.py
• dev-docs/FOLD_STATE_DIAGRAM.md
• dev-docs/agents.md
• dev-docs/messages.md
• dev-docs/teammates.md
• test/__snapshots__/test_snapshot_html.ambr
• test/__snapshots__/test_snapshot_markdown.ambr
• test/test_async_agents.py
• test/test_data/async_agents/README.md
• test/test_data/async_agents/eb000000-0000-4000-8000-000000000001.jsonl
• test/test_data/async_agents/eb000000-0000-4000-8000-000000000001/subagents/agent-cccc333.jsonl
• test/test_snapshot_html.py
• test/test_snapshot_markdown.py
• work/async-agents.md

✅ Files skipped from review due to trivial changes (4)

• test/test_data/async_agents/eb000000-0000-4000-8000-000000000001/subagents/agent-cccc333.jsonl
• dev-docs/FOLD_STATE_DIAGRAM.md
• dev-docs/agents.md
• dev-docs/messages.md

🚧 Files skipped from review as they are similar to previous changes (7)

• claude_code_log/html/utils.py
• test/test_snapshot_markdown.py
• claude_code_log/html/templates/components/teammate_styles.css
• claude_code_log/factories/tool_factory.py
• test/snapshots/test_snapshot_markdown.ambr
• claude_code_log/html/async_formatter.py
• test/test_async_agents.py