pool: New hotfile show command, and show enablement status with info -a#8067
Merged
greenc-FNAL merged 3 commits into11.2from Apr 14, 2026
Merged
pool: New hotfile show command, and show enablement status with info -a#8067greenc-FNAL merged 3 commits into11.2from
hotfile show command, and show enablement status with info -a#8067greenc-FNAL merged 3 commits into11.2from
Conversation
…fo -a`
Motivation:
It is desirable to have a single admin command to display the values of both hot-file migration parameters (`replicas` and `threshold`).
It is also desirable to see quickly whether the hot file migration facility is enabled on a given pool.
Modification:
- The addition of a pool command `hotfile show` to `MigrationModule`
- The hot file replication enablement status has been added to the `pool` section of `info -a`
Result:
- `hotfile show`
```
replicas=3 threshold=5
```
- `info -a`
```
…
--- pool (Main pool component) ---
Base directory : /diska/rw-pool-1
Version : 12.0.0-SNAPSHOT(bddeaa4) (Sub=4)
Report remove : ON
Pool Mode : enabled
Hsm Load Suppression : OFF
Ping Heartbeat : 30 seconds
Breakeven : 0.7
LargeFileStore : NONE
P2P File Mode : CACHED
Hot File Replication : ON
Mover Queue (DCap) 0(100)/0
Mover Queue (FTP) 0(30)/0
Mover Queue (TPC) 0(1000)/0
Mover Queue (XRootD) 0(1000)/0
Mover Queue (HTTP) 0(1000)/0
Mover Queue (NFS) 0(1000)/0
Mover Queue (regular) 0(1000)/0
Mover Queue (CVMFS) 0(10000)/0
…
```
Acked-by: Dmitry Litvintsev
Patch: https://rb.dcache.org/r/14640/diff/raw
Commit:
Target: master
Request: 11.2
Require-book: no
Require-notes: yes
There was a problem hiding this comment.
Pull request overview
Adds improved admin visibility into hot-file replication by introducing a consolidated hotfile show command and surfacing hot-file replication enablement in info -a pool details.
Changes:
- Added
hotfile showadmin command to display hot-file replication parameters (replicas,threshold). - Extended pool “details” output (
info -a) to include “Hot File Replication : ON|OFF”. - Added a unit test to verify the pool details output includes the hot-file replication status line.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/dcache/src/main/java/org/dcache/pool/migration/MigrationModule.java | Adds hotfile show command to display hot-file replication parameters. |
| modules/dcache/src/main/java/org/dcache/pool/json/PoolDataDetails.java | Adds hot-file replication enabled flag and prints it in pool details output (plus aligns labels). |
| modules/dcache/src/main/java/org/dcache/pool/classic/PoolV4.java | Populates PoolDataDetails with the pool’s hot-file replication enablement state. |
| modules/dcache/src/test/java/org/dcache/pool/json/PoolDataDetailsTest.java | New test verifying the printed pool details includes hot-file replication status. |
modules/dcache/src/main/java/org/dcache/pool/migration/MigrationModule.java
Show resolved
Hide resolved
modules/dcache/src/test/java/org/dcache/pool/json/PoolDataDetailsTest.java
Outdated
Show resolved
Hide resolved
modules/dcache/src/test/java/org/dcache/pool/json/PoolDataDetailsTest.java
Outdated
Show resolved
Hide resolved
…ilsTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
greenc-FNAL
added a commit
that referenced
this pull request
Apr 14, 2026
greenc-FNAL
added a commit
that referenced
this pull request
Apr 14, 2026
greenc-FNAL
added a commit
that referenced
this pull request
Apr 14, 2026
124b3fd to
46305e9
Compare
greenc-FNAL
added a commit
that referenced
this pull request
Apr 14, 2026
greenc-FNAL
added a commit
that referenced
this pull request
Apr 14, 2026
Motivation: [PR #8067](#8067) was intended to back-port https://rb.dcache.org/r/14640/ to the 11.2 release stream. [GitHub Copilot reviewd](#8067 (review)) this PR, producing three actionable comments addressed on that PR. We wish to reflect those changes on `master`. Modification: - `PoolDataDetailsTest.java` now properly flushes `PrintWriter` by means of try-with-resources. - Consistency/spacing issues with `PoolDataDetailsTest.java` diagnostics are corrected. - Correct inaccurate command description in `MigrationModule` to remove reference to hot file enablement status (moved to `info -a`). Result: - Command documentation for `hotfile show` is now correct. - `PoolDataDetailsTest.java` is now more robust, and has consistent diagnostic messages. Target: master Request: - Patch: https://rb.dcache.org/r/14670/diff/raw/ Closes: Requires-notes: no Requires-book: no Acked-by: Tigran Mkrtchyan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
It is desirable to have a single admin command to display the values of both hot-file migration parameters (
replicasandthreshold).It is also desirable to see quickly whether the hot file migration facility is enabled on a given pool.
Modification:
hotfile showtoMigrationModulepoolsection ofinfo -aResult:
hotfile showinfo -aAcked-by: Dmitry Litvintsev
Patch: https://rb.dcache.org/r/14640/diff/raw
Commit:
Target: master
Request: 11.2
Require-book: no
Require-notes: yes