Skip to content

pool: New hotfile show command, and show enablement status with info -a#8067

Merged
greenc-FNAL merged 3 commits into11.2from
fix/11.2/RB-14640
Apr 14, 2026
Merged

pool: New hotfile show command, and show enablement status with info -a#8067
greenc-FNAL merged 3 commits into11.2from
fix/11.2/RB-14640

Conversation

@greenc-FNAL
Copy link
Copy Markdown
Contributor

Motivation:

It is desirable to have a single admin command to display the values of both hot-file migration parameters (replicas and threshold).

It is also desirable to see quickly whether the hot file migration facility is enabled on a given pool.

Modification:

  • The addition of a pool command hotfile show to MigrationModule
  • The hot file replication enablement status has been added to the pool section of info -a

Result:

  • hotfile show

    replicas=3  threshold=5
    
  • info -a

    …
    --- pool (Main pool component) ---
    Base directory       : /diska/rw-pool-1
    Version              : 12.0.0-SNAPSHOT(bddeaa4) (Sub=4)
    Report remove        : ON
    Pool Mode            : enabled
    Hsm Load Suppression : OFF
    Ping Heartbeat       : 30 seconds
    Breakeven            : 0.7
    LargeFileStore       : NONE
    P2P File Mode        : CACHED
    Hot File Replication : ON
    Mover Queue (DCap) 0(100)/0
    Mover Queue (FTP) 0(30)/0
    Mover Queue (TPC) 0(1000)/0
    Mover Queue (XRootD) 0(1000)/0
    Mover Queue (HTTP) 0(1000)/0
    Mover Queue (NFS) 0(1000)/0
    Mover Queue (regular) 0(1000)/0
    Mover Queue (CVMFS) 0(10000)/0
    …
    

Acked-by: Dmitry Litvintsev
Patch: https://rb.dcache.org/r/14640/diff/raw
Commit:
Target: master
Request: 11.2
Require-book: no
Require-notes: yes

…fo -a`

Motivation:

It is desirable to have a single admin command to display the values of both hot-file migration parameters (`replicas` and `threshold`).

It is also desirable to see quickly whether the hot file migration facility is enabled on a given pool.

Modification:

- The addition of a pool command `hotfile show` to `MigrationModule`
- The hot file replication enablement status has been added to the `pool` section of `info -a`

Result:

- `hotfile show`

    ```
    replicas=3  threshold=5
    ```

- `info -a`

    ```
    …
    --- pool (Main pool component) ---
    Base directory       : /diska/rw-pool-1
    Version              : 12.0.0-SNAPSHOT(bddeaa4) (Sub=4)
    Report remove        : ON
    Pool Mode            : enabled
    Hsm Load Suppression : OFF
    Ping Heartbeat       : 30 seconds
    Breakeven            : 0.7
    LargeFileStore       : NONE
    P2P File Mode        : CACHED
    Hot File Replication : ON
    Mover Queue (DCap) 0(100)/0
    Mover Queue (FTP) 0(30)/0
    Mover Queue (TPC) 0(1000)/0
    Mover Queue (XRootD) 0(1000)/0
    Mover Queue (HTTP) 0(1000)/0
    Mover Queue (NFS) 0(1000)/0
    Mover Queue (regular) 0(1000)/0
    Mover Queue (CVMFS) 0(10000)/0
    …
    ```

Acked-by: Dmitry Litvintsev
Patch: https://rb.dcache.org/r/14640/diff/raw
Commit:
Target: master
Request: 11.2
Require-book: no
Require-notes: yes
Copilot AI review requested due to automatic review settings April 7, 2026 22:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds improved admin visibility into hot-file replication by introducing a consolidated hotfile show command and surfacing hot-file replication enablement in info -a pool details.

Changes:

  • Added hotfile show admin command to display hot-file replication parameters (replicas, threshold).
  • Extended pool “details” output (info -a) to include “Hot File Replication : ON|OFF”.
  • Added a unit test to verify the pool details output includes the hot-file replication status line.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
modules/dcache/src/main/java/org/dcache/pool/migration/MigrationModule.java Adds hotfile show command to display hot-file replication parameters.
modules/dcache/src/main/java/org/dcache/pool/json/PoolDataDetails.java Adds hot-file replication enabled flag and prints it in pool details output (plus aligns labels).
modules/dcache/src/main/java/org/dcache/pool/classic/PoolV4.java Populates PoolDataDetails with the pool’s hot-file replication enablement state.
modules/dcache/src/test/java/org/dcache/pool/json/PoolDataDetailsTest.java New test verifying the printed pool details includes hot-file replication status.

…ilsTest.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
greenc-FNAL added a commit that referenced this pull request Apr 14, 2026
Motivation:

[PR #8067](#8067) was intended to back-port https://rb.dcache.org/r/14640/ to the 11.2 release stream. [GitHub Copilot reviewd](#8067 (review)) this PR, producing three actionable comments addressed on that PR. We wish to reflect those changes on `master`.

Modification:

- `PoolDataDetailsTest.java` now properly flushes `PrintWriter` by means of try-with-resources.
- Consistency/spacing issues with `PoolDataDetailsTest.java` diagnostics are corrected.
- Correct inaccurate command description in `MigrationModule` to remove reference to hot file enablement status (moved to `info -a`).

Result:

- Command documentation for `hotfile show` is now correct.
- `PoolDataDetailsTest.java` is now more robust, and has consistent diagnostic messages.

Target: master
Request: -
Patch: https://rb.dcache.org/r/14670/diff/raw/
Closes:
Requires-notes: no
Requires-book: no
Acked-by: Tigran Mkrtchyan
@greenc-FNAL greenc-FNAL merged commit db2a697 into 11.2 Apr 14, 2026
1 of 3 checks passed
@greenc-FNAL greenc-FNAL deleted the fix/11.2/RB-14640 branch April 14, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants