pass a more descriptive error message for PhysAddr validation #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a routine calls PhysAddr->validate to validate an L2 address the descriptive message is lost by just returning a boolean success or failure. Instead allow passing in a reference to a scalar to give the calling function an opportunity to give the user more information about the specifics behind Netdot rejecting the MAC address they entered. Small amounts of whitespace formatting were performed in this commit as well as the functional changes. Changes such as removing trailing whitespace in functions that were touched and also replacing tabs with four spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a routine calls PhysAddr->validate to validate an L2 address the
descriptive message is lost by just returning a boolean success or
failure. Instead allow passing in a reference to a scalar to give the
calling function an opportunity to give the user more information about
the specifics behind Netdot rejecting the MAC address they entered.
Small amounts of whitespace formatting were performed in this commit as
well as the functional changes. Changes such as removing trailing
whitespace in functions that were touched and also replacing tabs with
four spaces.