Repository navigation
test(ranges): run tests against core's snapshot data at a fixed date - #91
Merged
Merged
Conversation
the ranges tests fetched the live index.json and schedule.json and used today's clock, so they broke whenever the real schedule left a range empty. on 2026-10-20 no line is in Active LTS, which made lts/latest disappear and failed 5 tests. add test/fixtures.js, which serves core's checked-in snapshots filtered to 2025-09-01 and throws on any other URL. pass it to every ranges call, reuse it in alpha.test.js, add a test that pins each range's newest/oldest/security/lts values on that date, scope the test scripts to *.test.js, and widen the tests-ranges workflow path filter to ranges/** and core's snapshot data.
the ranges tests now run the workspace core and aliases, not just core's snapshot data, so changes to either should trigger them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #90. The ranges tests fetched the live index.json and schedule.json and ran against today's date. On 2026-10-20 v24 moved to maintenance and v26 isn't LTS until 2026-10-28, so
lts/latestcame back empty, got deleted, and 5 tests threw onundefined.Added:
ranges/test/fixtures.jsserves core's checked-in snapshots through thefetchoption, keeps only releases out by the given date (default 2025-09-01), and throws on any other URL. On that date v24 is Current, v22 Active LTS, v20 Maintenance and v23 EOL, so every range has versions. A new test inknown.test.jspins each range's newest, oldest, security and LTS values; the older tests missed a mutation that routed maintenance releases intolts/latest.Changed: every ranges call in the tests passes the fixture options, with no assertions changed.
alpha.test.jsuses the shared helper. Thetestandcoveragescripts runtest/*.test.jsso the helper isn't counted as a test. The tests-ranges workflow now triggers onranges/**andcore/test/data/static/**; the oldranges/*filter skipped changes underranges/test/.