Repository navigation
chore(lint): upgrade biome to 2.5.15 - #100
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uppt rewrites every workspace package.json with
JSON.stringifyon each release bump, which puts eachfilesandkeywordsentry on its own line. Biome 1.9.4 collapses short arrays, so every release PR failed lint (the v1.1.0 PR, #85, needed a manual reformat). Biome 2 formats package.json the same way npm does, which matches uppt's output.Changed:
@biomejs/biomegoes from 1.9.4 to 2.5.15 in all 10 workspaces, still pinned exactly.biome.jsonis migrated to the 2.x schema (organizeImportsunderassist,preset: "recommended")."root": falsewith"extends": "//". static keeps itsfiles.maxSizeoverride.filesandkeywordsarrays in every package.json, root included, are now one entry per line.Removed, in a second commit, what Biome 2's recommended preset flags as unused: the
beforeEach,DateTimeandnodevuimports in core'sparseOptions.js,schedule.jsandversions.jstests, the unusedlineloop variable inschedule.js, and thefilenameparameter of the fourstatic/build/*.jsscripts, which are each called with no arguments. Two warnings remain incore/test/schedule.js: the "optionsParser" tests assigndataand never check it, so they assert nothing. That fix changes what the tests cover, so it goes in its own PR.npm run lintandnpm test --wspass from a clean install. A uppt-style rewrite of each published package.json differs from the committed file only in the version line.