IS-11176: Add prettier check to CI workflow#122
Merged
aleixsuau merged 7 commits intointegration/IS-5161/login-web-appfrom Apr 22, 2026
Merged
Conversation
vahag-curity
approved these changes
Apr 14, 2026
urre
approved these changes
Apr 14, 2026
aleixsuau
force-pushed
the
feature/IS-11176/add-prettier-check-to-ci
branch
2 times, most recently
from
f05064a to
3d98133
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The previous `src/shared/ui/icons/*` pattern only matched direct children, leaving nested generated .d.ts files under types/components/ exposed to the prettier-check CI step. Using a trailing slash ignores the whole tree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When running from the repo root, prettier only looks for .prettierignore in the cwd. The workspace's ignore file (with generated-icon exclusions) was being ignored, so CI flagged 68 false positives locally passing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aleixsuau
force-pushed
the
feature/IS-11176/add-prettier-check-to-ci
branch
from
d227e84 to
7042db1
Compare
The CI prettier step now runs via `npm run prettier-check -w src/login-web-app`,
which uses the workspace cwd and picks up .prettierignore naturally. This
widened the scope beyond `src/**/*.{ts,tsx}` to include previewer sources
and root vite configs, surfacing pre-existing 4-space indentation drift.
Reformatted to 2-space indent (tabWidth: 2).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Both paths no longer exist under login-web-app: - `src/shared/ui/icons/` — icons are now imported from @curity/ui-kit-icons (the common workspace package). - `src/shared/util/css/index.css` — removed by IS-11235; only styles.css remains in that folder. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettier --checkstep to the LWA CI workflow so formatting issues are caught before mergeTest plan