🎨 Palette: Add aria-hidden to decorative GitHub icon in Hero - #153
🎨 Palette: Add aria-hidden to decorative GitHub icon in Hero#153google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
💡 What
Added
aria-hidden="true"to the decorative<SiGithub />icon component inside the GitHub link button inapp/components/Hero/index.tsx.🎯 Why
The GitHub button already has visible, descriptive text content ("GitHub") and an accessible screen-reader-only announcement for opening in a new window ("(opens in a new window)"). Without
aria-hidden="true", the decorative SVG icon could produce redundant, verbose, or noisy announcements in screen readers.📸 Before/After
Visually unchanged; screen readers will now cleanly announce "GitHub (opens in a new window)" without reading out unhandled inner SVG paths.
♿ Accessibility
tests/unit/components/Hero/index.test.tsx.PR created automatically by Jules for task 6505446576525670885 started by @amrabed