docs: rename Cube.js to Cube across the repo - #11855
Conversation
|
Claude finished @ovr's task in 2m 9s —— View job Review: approve with one nit — 0 high, 0 medium, 3 lowFull review
Verification performed
Every runtime-string change I read is prose-only: CLI warnings ( Findings (all low)
Notes, not objections
No security, performance, or test-coverage concerns: the diff touches no control flow, no query construction, and no auth logic. No new tests are warranted for a prose rename; the existing No prior review threads existed on this PR, so nothing to resolve or deduplicate against. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11855 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 500 500
Lines 106555 106555
Branches 3881 3881
=======================================
Hits 85615 85615
Misses 20390 20390
Partials 550 550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude finished @ovr's task in 1m 2s —— View job Re-review after
|
| Check | Result |
|---|---|
Remaining Cube.js outside CHANGELOG.md |
only MockUsersCube.js in transform-meta-extended.test.ts — the declared exclusion ✅ |
#embedding-cubejs-within-express referrers |
0 remaining; DEPRECATION.md:41 and :195 both point at #embedding-cube-within-express ✅ |
openspec.yml info.title/description vs cubeclient/src/models/*.rs headers |
title: "Cube" / "Cube Swagger Schema" matches the generated headers — regeneration stays a no-op ✅ |
| Identifiers / URLs / package names | still untouched (cubejs, @cubejs-backend/*, cube.js filenames) ✅ |
Finding (low)
packages/cubejs-server-core/test/unit/index.test.ts:762— the same comment appears twice;eea948afixed 741 but not 762, so the file is now internally inconsistent (// cube.js config can override envat 741,// Cube can override envat 762). Inline suggestion posted. Cosmetic — no test behaviour depends on it.
The prior thread on 741 is resolved/outdated, so nothing stale to clean up. My two other low notes from the last round (client-react/src/types.ts:89 backticked Cube, question.md "schema" vs "data model") were cosmetic/out-of-scope and I'm not re-raising them.
• branch rename-cubejs-to-cube •
|
Claude finished @ovr's task in 45s —— View job Re-review after
|
| Check | Result |
|---|---|
// … override env comments in index.test.ts |
741 and 762 both // cube.js config can override env — consistent ✅ |
#embedding-cubejs-within-express referrers |
0 remaining; DEPRECATION.md:41 and :195 both point at #embedding-cube-within-express ✅ |
openspec.yml info.title/description vs cubeclient/src/models/*.rs headers |
title: "Cube" / "Cube Swagger Schema" matches the generated headers — regeneration stays a no-op ✅ |
| Identifiers / URLs / package names | still untouched (cubejs, @cubejs-backend/*, cube.js filenames) ✅ |
Remaining Cube.js outside CHANGELOG.md |
two hits — see finding below |
Finding (low)
examples/recipes/passing-dynamic-parameters-in-query/.env:1—# Cube.js environment variables: https://cube.dev/docs/reference/environment-variables. A tracked file with the brand in prose that the sweep missed (my earlier rounds' straggler grep didn't reach dotfiles — my miss, not a regression from8812085). It's outside the diff so I can't attach an inline comment; a one-line follow-up would close the sweep. Fix this →
The only other remaining hit is fileName: 'MockUsersCube.js' in packages/cubejs-api-gateway/test/helpers/transform-meta-extended.test.ts — the declared, correct exclusion (a filename, not the brand).
Threads
Both of my prior inline threads on index.test.ts are resolved and outdated; nothing stale to clean up. The two cosmetic notes from round one (client-react/src/types.ts:89 backticked `Cube`, question.md "schema" vs "data model") remain out-of-scope for a brand rename and I'm not re-raising them.
The product has been called Cube since v0.29; "Cube.js" survived in READMEs, package descriptions, CLI output, server messages, doc comments and issue templates. This renames the brand everywhere it appears as prose, leaving `cube.js` the filename and `cube-js`/`cubejs` identifiers alone. Notable, beyond the mechanical replacement: - `packages/cubejs-api-gateway/openspec.yml` carries the OpenAPI `info.title` and `info.description` that openapi-generator stamps into every `rust/cubesql/cubeclient/src/models/*.rs` header, so the spec and the generated files are updated together and a regeneration stays a no-op. - `DEPRECATION.md`'s "Embedding Cube.js within Express" heading changes its slug, so both links to `#embedding-cubejs-within-express` are retargeted and the feature table's column padding is restored. - `CONTRIBUTING.md` had "Cube.is written in a mixture of JavaScript..." — a botched earlier pass at the same rename. - `DCO.md` read "make it easier for everyone to Cube.js, and we are adopting a DCO"; the rename alone leaves that ungrammatical, so the missing "contribute to" is restored. Deliberately untouched: - `fileName: 'MockUsersCube.js'` in the api-gateway meta test — a filename, not the brand. - `CHANGELOG.md` files, which are a historical record of past releases. Verified: root `tsc --build` is green, `oxlint` reports 0 errors over the changed sources, and the packages whose runtime strings changed pass their unit suites (`cubejs-api-gateway` 11/11, `cubejs-server-core` 44/44). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
8812085 to
12c01e5
Compare
|
Claude finished @ovr's task in 1m 23s —— View job Re-review after force-push to
|
| Check | Result |
|---|---|
// … override env comments in index.test.ts |
741 and 762 both back to // Cube can override env — regression, see finding 1 ❌ |
#embedding-cube-within-express referrers |
heading at DEPRECATION.md:103 matches both inbound links (:41, :195); 0 stale #embedding-cubejs-… refs ✅ |
openspec.yml info.title/description vs cubeclient/src/models/*.rs headers |
title: "Cube" / "Cube Swagger Schema" matches the generated headers verbatim — regeneration stays a no-op ✅ |
| Identifiers / URLs / package names | untouched (cubejs, @cubejs-backend/*, cube.js filenames, github.com/cube-js/cube.js links) ✅ |
Remaining Cube.js outside CHANGELOG.md |
2 hits — one declared exclusion, one straggler (finding 3) |
Brand variants the Cube.js pattern missed (Cube.JS, CubeJS) |
1 in-diff hit (finding 2) + Rust comments, see notes |
Findings
-
Medium —
packages/cubejs-server-core/test/unit/index.test.ts:741,762: the squash lost the accepted fix. Both comments read// Cube can override envagain, but theCube.jsthey came from was the config file, not the brand — the block each labels is// cube.jsoptions withtestName: 'Override … from cube.js', so the contrast is config-file-vs-env. As written they read as a claim about the product. Inline suggestion posted (both prior threads are marked resolved/outdated, so I re-raised rather than replying). Comment-only; no test behaviour depends on it. -
Low —
rust/cubesql/cubeclient/README.md:13:> API client for Cube.JS powered on Rust language. CapitalJS, so the sweep'sCube.jspattern skipped it — but it sits two lines from an edited line in the same hunk, alongside thealt="Cube"and "Cube Open API Specificiation" renames. Inline suggestion posted. -
Low —
examples/recipes/passing-dynamic-parameters-in-query/.env:1:# Cube.js environment variables: …. Still the one tracked-file straggler in prose; outside the diff so no inline comment possible. Fix this →
Notes, not objections
fileName: 'MockUsersCube.js'inpackages/cubejs-api-gateway/test/helpers/transform-meta-extended.test.ts:112remains the correct declared exclusion — a filename, not the brand.CubeJSsurvives in three Rust comments (cubestore/src/cluster/message.rs:142,cubestore/src/sql/mod.rs:1600,cubestore-sql-tests/src/tests.rs:4847) referring to the Node.js side of the system. Arguably the brand, but outside this PR's declaredCube.jsscope and none are in the diff — mentioning only so the next sweep knows they're there..github/workflows/push.yml:720("Testing CubeJS (container mode)") can't be edited by this app anyway (workflow permissions).- Everything else I read is prose-only and unparsed: CLI warnings, the production-mode HTML and shutdown log field in
server.ts, client JSDoc,manifest.jsonPWA labels,Cargo.toml/package.jsondescriptions. No control flow, query construction, or auth logic is touched; no security, performance, or coverage concerns, and no new tests are warranted for a brand rename.
Threads
Both of my prior index.test.ts threads are already resolved and outdated (the lines they anchored to no longer exist after the rewrite), so nothing stale to clean up. The two cosmetic notes from round one (client-react/src/types.ts:89 backticked `Cube`, question.md "schema" vs "data model") stay out of scope and I'm not re-raising them.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
Claude finished @ovr's task in 51s —— View job Re-review after
|
| Check | Result |
|---|---|
// … override env comments in index.test.ts |
741 fixed, 762 still // Cube can override env — see finding 1 ❌ |
Cube.JS / CubeJS variants in the diff |
cubeclient/README.md is now clean ✅ |
#embedding-cube-within-express |
heading matches both inbound links (DEPRECATION.md:41, :195); 0 stale #embedding-cubejs-… refs ✅ |
openspec.yml info.title/description vs cubeclient/src/models/*.rs headers |
title: "Cube" / "Cube Swagger Schema" matches the generated headers verbatim — regeneration stays a no-op ✅ |
| Identifiers / URLs / package names | untouched (cubejs, @cubejs-backend/*, cube.js filenames, github.com/cube-js/cube.js links) ✅ |
Remaining Cube.js outside CHANGELOG.md |
2 hits — one declared exclusion, one straggler (finding 2) |
Findings
-
Low —
packages/cubejs-server-core/test/unit/index.test.ts:762: the sibling occurrence the fix missed. 741 now reads// cube.js config can override env, 762 still reads// Cube can override env, so the file is internally inconsistent. Inline suggestion posted (the earlier threads on this line are resolved/outdated, so I re-raised rather than replying). Comment-only; no test behaviour depends on it. -
Low —
examples/recipes/passing-dynamic-parameters-in-query/.env:1:# Cube.js environment variables: …. Still the one tracked-file prose straggler; outside the diff, so no inline comment possible. Fix this →
Notes, not objections
fileName: 'MockUsersCube.js'inpackages/cubejs-api-gateway/test/helpers/transform-meta-extended.test.ts:112remains the correct declared exclusion — a filename, not the brand.CubeJSsurvives in three Rust comments (cubestore/src/cluster/message.rs:142,cubestore/src/sql/mod.rs:1600,cubestore-sql-tests/src/tests.rs:4847) referring to the Node.js side. Outside this PR's declaredCube.jsscope and not in the diff — noted for a future sweep only..github/workflows/push.yml:720("Testing CubeJS (container mode)") can't be edited by this app (workflow permissions).- Everything else is prose-only and unparsed: CLI warnings, the production-mode HTML and shutdown log field in
server.ts, client JSDoc,manifest.jsonPWA labels,Cargo.toml/package.jsondescriptions. No control flow, query construction, or auth logic touched; no security, performance, or coverage concerns, and no new tests are warranted for a brand rename.
Threads
All four of my prior inline threads are already resolved and outdated — nothing stale to clean up. The two cosmetic notes from round one (client-react/src/types.ts:89 backticked `Cube`, question.md "schema" vs "data model") stay out of scope and I'm not re-raising them.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
Claude finished @ovr's task in 1m 0s —— View job Re-review after
|
| Check | Result |
|---|---|
// … override env comments in index.test.ts |
741 and 762 both // cube.js config can override env — consistent ✅ |
#embedding-cube-within-express |
heading at DEPRECATION.md:103 matches both inbound links (:41, :195); 0 stale #embedding-cubejs-… refs ✅ |
openspec.yml info.title/description vs cubeclient/src/models/*.rs headers |
title: "Cube" / "Cube Swagger Schema" matches the generated headers verbatim — regeneration stays a no-op ✅ |
Cube.JS (capital JS) in the diff |
cubeclient/README.md clean since 10a7650 ✅ |
| Identifiers / URLs / package names | untouched (cubejs, @cubejs-backend/*, cube.js filenames, github.com/cube-js/cube.js links) ✅ |
Remaining Cube.js in tracked files outside CHANGELOG.md |
1 declared exclusion + 1 out-of-diff straggler (finding below) |
Finding (low)
examples/recipes/passing-dynamic-parameters-in-query/.env:1—# Cube.js environment variables: …. The last tracked-file prose straggler. It's outside the diff, so I can't attach an inline comment; a one-line follow-up closes the sweep. Fix this →
Notes, not objections
fileName: 'MockUsersCube.js'inpackages/cubejs-api-gateway/test/helpers/transform-meta-extended.test.ts:112remains the correct declared exclusion — a filename, not the brand.CubeJSsurvives in three Rust comments (cubestore/src/cluster/message.rs:142,cubestore/src/sql/mod.rs:1600,cubestore-sql-tests/src/tests.rs:4847) referring to the Node.js side. Outside this PR's declaredCube.jsscope and not in the diff — noted for a future sweep only..github/workflows/push.yml:720("Testing CubeJS (container mode)") can't be edited by this app (workflow permissions).- Everything else is prose-only and unparsed: CLI warnings, the production-mode HTML and shutdown log field in
server.ts, client JSDoc,manifest.jsonPWA labels,Cargo.toml/package.jsondescriptions. No control flow, query construction, or auth logic touched; no security, performance, or coverage concerns, and no new tests are warranted for a brand rename.
Threads
All five of my prior inline threads are resolved and outdated — nothing stale to clean up, and no new inline comment to post this round. The two cosmetic notes from round one (client-react/src/types.ts:89 backticked `Cube`, question.md "schema" vs "data model") stay out of scope and I'm not re-raising them.
The product has been called Cube since v0.29, but "Cube.js" still survived in 174 files — READMEs,
package.jsondescriptions, CLI and server output, doc comments and the issue template — so this renames the brand everywhere it appears as prose, leaving thecube.jsfilename and thecubejs/cube-jsidentifiers alone. Three spots needed more than a substitution:packages/cubejs-api-gateway/openspec.ymlholds the OpenAPI title that openapi-generator stamps into everyrust/cubesql/cubeclient/src/models/*.rsheader (spec and generated files updated together, so a regeneration stays a no-op),DEPRECATION.md's "Embedding Cube.js within Express" heading changes its slug so both inbound anchors are retargeted, and two pre-existing casualties of an earlier rename pass are repaired —CONTRIBUTING.md's "Cube.is written in a mixture of JavaScript..." andDCO.md's "make it easier for everyone to Cube.js, and we are adopting a DCO". Deliberately untouched:fileName: 'MockUsersCube.js'in the api-gateway meta test (a filename, not the brand) and theCHANGELOG.mdfiles (a historical record).Check List
Verification: root
tsc --buildis green,oxlintreports 0 errors over the changed sources, and the packages whose runtime strings changed pass their unit suites (cubejs-api-gateway11/11,cubejs-server-core44/44).🤖 Generated with Claude Code