Skip to content

feat!: Remove deprecated CUBEJS_SCHEDULED_REFRESH_CONCURRENCY env var…#11048

Open
ovr wants to merge 1 commit into
feat/release-v1.7.0from
feat/remove-scheduled-refresh-concurrency
Open

feat!: Remove deprecated CUBEJS_SCHEDULED_REFRESH_CONCURRENCY env var…#11048
ovr wants to merge 1 commit into
feat/release-v1.7.0from
feat/remove-scheduled-refresh-concurrency

Conversation

@ovr

@ovr ovr commented Jun 9, 2026

Copy link
Copy Markdown
Member

…iable

BREAKING CHANGE: The CUBEJS_SCHEDULED_REFRESH_CONCURRENCY environment variable has been removed. It was deprecated in v1.2.7. Use CUBEJS_SCHEDULED_REFRESH_QUERIES_PER_APP_ID instead.

…iable

BREAKING CHANGE: The CUBEJS_SCHEDULED_REFRESH_CONCURRENCY environment variable has been removed. It was deprecated in v1.2.7. Use CUBEJS_SCHEDULED_REFRESH_QUERIES_PER_APP_ID instead.
@ovr ovr requested review from a team and keydunov as code owners June 9, 2026 19:51
@github-actions github-actions Bot added the javascript Pull requests that update Javascript code label Jun 9, 2026
@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ovr's task in 37s —— View job


Code Review

Verdict: LGTM — clean breaking-change removal. 0 high, 0 medium, 0 low.

Review details

Tasks

  • Read diff against origin/feat/release-v1.7.0
  • Verify no remaining runtime references to CUBEJS_SCHEDULED_REFRESH_CONCURRENCY
  • Verify callers of scheduledRefreshQueriesPerAppId still work
  • Check docs sync (mintlify + legacy)
  • Check DEPRECATION.md entry consistency

Findings

packages/cubejs-backend-shared/src/env.ts — the scheduledRefreshQueriesPerAppId getter now cleanly reads only the new env var. The deprecation warning fallback is removed, which is the intended behavior for v1.7.0 since the var was deprecated in v1.2.7. The sole caller in packages/cubejs-server-core/src/core/OptsHandler.ts:478 (scheduledRefreshConcurrency: getEnv('scheduledRefreshQueriesPerAppId')) continues to work unchanged.

DEPRECATION.md — table row correctly flipped from Deprecated → Removed with v1.7.0, and the section body adds a matching "Removed in Release: v1.7.0" line. Consistent with the prior Elasticsearch driver removal in the same release.

Docs (docs-mintlify/... and docs/content/...) — both the active Mintlify docs and the legacy docs site have their "previously named" Info/InfoBox callouts removed. Per CLAUDE.md, /docs is deprecated and edits should normally be avoided, but pruning a stale reference there is fine and keeps the two sites consistent.

No remaining references — only hits for CUBEJS_SCHEDULED_REFRESH_CONCURRENCY in the repo are now in historical CHANGELOG.md files (correctly left alone) and DEPRECATION.md (intentional).

Optional nits

  • None. The change is minimal, scoped, and self-consistent with the release-v1.7.0 train of breaking removals.
• Branch: `feat/remove-scheduled-refresh-concurrency`

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/release-v1.7.0@ebb6f2f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/env.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             feat/release-v1.7.0   #11048   +/-   ##
======================================================
  Coverage                       ?   58.74%           
======================================================
  Files                          ?      214           
  Lines                          ?    17170           
  Branches                       ?     3503           
======================================================
  Hits                           ?    10086           
  Misses                         ?     6569           
  Partials                       ?      515           
Flag Coverage Δ
cube-backend 58.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants