Skip to content

feat: v1.7.0 -> master#11042

Draft
ovr wants to merge 3 commits into
masterfrom
feat/release-v1.7.0
Draft

feat: v1.7.0 -> master#11042
ovr wants to merge 3 commits into
masterfrom
feat/release-v1.7.0

Conversation

@ovr

@ovr ovr commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@ovr ovr requested review from a team and keydunov as code owners June 9, 2026 14:00
@github-actions github-actions Bot added docs Issues that require a documentation improvement driver:elasticsearch Issues relating to the ElasticSearch driver javascript Pull requests that update Javascript code data source driver labels Jun 9, 2026
@ovr ovr force-pushed the feat/release-v1.7.0 branch from 0438bc5 to bfbca37 Compare June 9, 2026 14:05
@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ovr's task in 59s —— View job


Code Review — v1.7.0 release / Elasticsearch driver removal

One-line headline: LGTM — clean removal of the deprecated Elasticsearch driver. 0 high, 0 medium, 1 low.

Full review (click to expand)

Checklist

  • Gather PR context
  • Verify no stale references in source
  • Check DEPRECATION.md is consistent
  • Review redirect/docs removals
  • Post review

Summary

This PR removes the @cubejs-backend/elasticsearch-driver package and all wiring for the elasticsearch / awselasticsearch database types. The driver was deprecated in v1.6.0 (per DEPRECATION.md:70) and the removal is being shipped in v1.7.0 as documented (DEPRECATION.md:426-432), so the deprecation policy is respected.

What I verified

  • No remaining source references to elasticsearch / awselasticsearch / ElasticSearchQuery / AWSElasticSearchQuery / elasticApi* / elasticOpenDistro / elasticQueryFormat outside CHANGELOG files (historical) and DEPRECATION.md (intentional).
  • DriverDependencies.ts, DatabaseType union in types.ts, and the ADAPTERS map in QueryBuilder.ts are all updated consistently — no orphaned references.
  • The four CUBEJS_DB_ELASTIC_* env vars are dropped together with their tests in db_env_single.test.ts / db_env_multi.test.ts — symmetric and clean.
  • Docker build (dev.Dockerfile, testing-drivers.Dockerfile) and package.json no longer pull the driver.
  • Both legacy (/docs) and active (/docs-mintlify) docs sites are updated; the deprecated /docs edits are unavoidable here since the redirect/env-var pages live there too.

Findings

Low — Removed redirects will now 404 instead of redirecting

docs/redirects.json and docs/redirects-new-docs.json drop the /config/databases/elasticsearch and /product/configuration/data-sources/elasticsearch entries. External links and search results pointing at those URLs will now 404. Since the destination pages also no longer exist, a perfect-fit redirect doesn't exist either, but consider pointing them at the data-sources index page (/product/configuration/data-sources / /admin/connect-to-data/data-sources) so users land somewhere useful and can see this driver is no longer supported. Optional — not a blocker.

Nits

  • DEPRECATION.md:432 — "The Elasticsearch driver has been removed." Consider a one-liner suggesting an alternative path (e.g., use the SQL gateway / OpenSearch SQL plugin via JDBC, or another driver) so users who hit this know what to do next. Not strictly required.

Not reviewed

  • CI workflow (.github/workflows/push.yml) — only a label change, looks consistent with the labeler.yml updates.
• Branch: `feat/release-v1.7.0`

BREAKING CHANGE: The Elasticsearch driver has been removed. It was deprecated in v1.6.0. There is no drop-in replacement.
@ovr ovr force-pushed the feat/release-v1.7.0 branch from bfbca37 to ebb6f2f Compare June 9, 2026 14:07
@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ovr's task in 38s —— View job


Code Review — v1.7.0 release / Elasticsearch driver removal

One-line headline: LGTM — clean removal of the deprecated Elasticsearch driver. 0 high, 0 medium, 1 low. (Re-affirmed: no new commits since the prior review — HEAD is still ebb6f2f.)

Full review (click to expand)

Checklist

  • Gather PR context
  • Verify no stale references in source
  • Check DEPRECATION.md is consistent
  • Review redirect/docs removals
  • Re-verify on synchronize (no diff change)

Summary

This PR removes the @cubejs-backend/elasticsearch-driver package and all wiring for the elasticsearch / awselasticsearch database types. The driver was deprecated in v1.6.0 (per DEPRECATION.md:70) and the removal is being shipped in v1.7.0 as documented (DEPRECATION.md:426-432), so the deprecation policy is respected.

What I verified

  • No remaining source references to elasticsearch / awselasticsearch / ElasticSearchQuery / AWSElasticSearchQuery / elasticApi* / elasticOpenDistro / elasticQueryFormat outside CHANGELOG files (historical) and DEPRECATION.md (intentional).
  • DriverDependencies.ts, DatabaseType union in types.ts, and the ADAPTERS map in QueryBuilder.ts are all updated consistently — no orphaned references.
  • The four CUBEJS_DB_ELASTIC_* env vars are dropped together with their tests in db_env_single.test.ts / db_env_multi.test.ts — symmetric and clean.
  • Docker build (dev.Dockerfile, testing-drivers.Dockerfile) and package.json no longer pull the driver.
  • Both legacy (/docs) and active (/docs-mintlify) docs sites are updated; the deprecated /docs edits are unavoidable here since the redirect/env-var pages live there too.

Findings

Low — Removed redirects will now 404 instead of redirecting

docs/redirects.json and docs/redirects-new-docs.json drop the /config/databases/elasticsearch and /product/configuration/data-sources/elasticsearch entries. External links and search results pointing at those URLs will now 404. Since the destination pages also no longer exist, a perfect-fit redirect doesn't exist either, but consider pointing them at the data-sources index page (/product/configuration/data-sources / /admin/connect-to-data/data-sources) so users land somewhere useful and can see this driver is no longer supported. Optional — not a blocker.

Nits

  • DEPRECATION.md:432 — "The Elasticsearch driver has been removed." Consider a one-liner suggesting an alternative path (e.g., use the SQL gateway / OpenSearch SQL plugin via JDBC, or another driver) so users who hit this know what to do next. Not strictly required.

Not reviewed

  • CI workflow (.github/workflows/push.yml) — only a label change, looks consistent with the labeler.yml updates.

• Branch: feat/release-v1.7.0

…11044)

BREAKING CHANGE: The running_total measure type has been removed. Data models that use `type: running_total` will now fail validation. Replace them with a rolling_window measure using an unbounded trailing window.
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Jun 10, 2026
…iable (#11048)

BREAKING CHANGE: The CUBEJS_SCHEDULED_REFRESH_CONCURRENCY environment variable has been removed. It was deprecated in v1.2.7. Use CUBEJS_SCHEDULED_REFRESH_QUERIES_PER_APP_ID instead.
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.09%. Comparing base (d91df4b) to head (e2d8258).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-backend-shared/src/env.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11042       +/-   ##
===========================================
+ Coverage   58.51%   79.09%   +20.58%     
===========================================
  Files         216      470      +254     
  Lines       17265    95766    +78501     
  Branches     3524     3500       -24     
===========================================
+ Hits        10102    75747    +65645     
- Misses       6648    19504    +12856     
  Partials      515      515               
Flag Coverage Δ
cube-backend 58.69% <50.00%> (+0.18%) ⬆️
cubesql 83.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver docs Issues that require a documentation improvement driver:elasticsearch Issues relating to the ElasticSearch driver javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant