[feature] add rewrite-command flag to mark commands needing rewrite - #438
Open
qiongtubao wants to merge 1 commit into
Open
[feature] add rewrite-command flag to mark commands needing rewrite#438qiongtubao wants to merge 1 commit into
qiongtubao wants to merge 1 commit into
Conversation
qiongtubao
force-pushed
the
feature/gtid_rewrite_commands
branch
4 times, most recently
from
July 30, 2026 08:17
3955c39 to
e35e261
Compare
Introduce CMD_REWRITE_COMMAND (1ULL<<40) and parse the 'rewrite-command' string flag in commandFlagsFromString. Apply the flag to the relevant write/blocking commands in both the native redisCommandTable (src/server.c) and the swap command table (src/ctrip_swap_cmd.c) so they can be identified as commands that require rewriting. Also add tests/support/gtid_version.tcl symlink and bump the xredis-gtid submodule.
qiongtubao
force-pushed
the
feature/gtid_rewrite_commands
branch
from
July 30, 2026 11:09
e35e261 to
1ace699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce CMD_REWRITE_COMMAND (1ULL<<40) and parse the 'rewrite-command' string flag in commandFlagsFromString. Apply the flag to the relevant write/blocking commands in both the native redisCommandTable (src/server.c) and the swap command table (src/ctrip_swap_cmd.c) so they can be identified as commands that require rewriting. Also add tests/support/gtid_version.tcl symlink and bump the xredis-gtid submodule.