Remove space from email display name by landonshumway-ia · Pull Request #1462 · csg-org/CompactConnect

landonshumway-ia · 2026-04-13T21:26:49Z

The display name for the email addresses was originally configured with a space between Compact and Connect. This display name is specified by an IAM policy that must be updated in order to specify the corrected 'CompactConnect' display name. To avoid downtime, we need to update the policy to support both during the first deployment, then remove the old policy once the change is verified in production.

This also makes several needed dependency updates in an attempt to cut down on the many Dependabot PRs we currently have in place.

Closes #1428

Summary by CodeRabbit

Chores
- Standardized branding from "Compact Connect" → "CompactConnect" across outgoing emails, templates, documentation, package metadata, and IAM/email permissions.
- Bumped multiple Python and Node.js dependency versions (AWS SDKs, testing tools, nodemailer types, etc.).
Tests
- Updated test expectations to match the revised sender display name and adjusted email subjects/bodies.

coderabbitai · 2026-04-13T21:26:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e80183c-ca49-443d-aed9-8850cf4cef0d

📥 Commits

Reviewing files that changed from the base of the PR and between 343c920 and 1be8ecc.

📒 Files selected for processing (16)

backend/compact-connect/README.md
backend/compact-connect/app_clients/README.md
backend/compact-connect/app_clients/bin/create_app_client.py
backend/compact-connect/docs/README.md
backend/compact-connect/docs/attestations/README.md
backend/compact-connect/docs/devops/README.md
backend/compact-connect/docs/devops/STAFF_USER_MFA_RECOVERY.md
backend/compact-connect/docs/onboarding/JURISDICTION_COMPACT_ONBOARDING.md
backend/cosmetology-app/README.md
backend/cosmetology-app/app_clients/README.md
backend/cosmetology-app/app_clients/bin/create_app_client.py
backend/cosmetology-app/docs/README.md
backend/cosmetology-app/docs/devops/README.md
backend/cosmetology-app/docs/devops/STAFF_USER_MFA_RECOVERY.md
backend/cosmetology-app/lambdas/nodejs/email-notification-service/README.md
backend/cosmetology-app/stacks/persistent_stack/__init__.py

✅ Files skipped from review due to trivial changes (15)

backend/compact-connect/docs/devops/README.md
backend/cosmetology-app/docs/devops/README.md
backend/cosmetology-app/app_clients/README.md
backend/cosmetology-app/lambdas/nodejs/email-notification-service/README.md
backend/compact-connect/docs/devops/STAFF_USER_MFA_RECOVERY.md
backend/compact-connect/docs/README.md
backend/cosmetology-app/app_clients/bin/create_app_client.py
backend/cosmetology-app/docs/devops/STAFF_USER_MFA_RECOVERY.md
backend/cosmetology-app/README.md
backend/compact-connect/app_clients/bin/create_app_client.py
backend/compact-connect/app_clients/README.md
backend/compact-connect/README.md
backend/compact-connect/docs/attestations/README.md
backend/compact-connect/docs/onboarding/JURISDICTION_COMPACT_ONBOARDING.md
backend/cosmetology-app/docs/README.md

📝 Walkthrough

Walkthrough

The PR standardizes branding by replacing "Compact Connect" with "CompactConnect" across Node.js email code, tests, package metadata, and docs; upgrades nodemailer/@types; updates IAM SES policy conditions to allow both old and new FromDisplayName values for migration; and bumps many Python dev/runtime dependency pins.

Changes

Cohort / File(s)	Summary
Compact-Connect Node.js Email & Templates `backend/compact-connect/lambdas/nodejs/lib/email/base-email-service.ts`, `backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts`, `backend/compact-connect/lambdas/nodejs/package.json`	Changed sender/display name to `CompactConnect` in SES/Nodemailer usage and email templates; bumped `nodemailer` and `@types/nodemailer`.
Compact-Connect Node.js Tests `backend/compact-connect/lambdas/nodejs/tests/...`, `backend/compact-connect/lambdas/nodejs/tests/lib/email/*.test.ts`	Updated expected `FromEmailAddress`, subject lines, and asserted body text to match `CompactConnect`.
Cosmetology-App Node.js Email & Tests `backend/cosmetology-app/lambdas/nodejs/lib/email/base-email-service.ts`, `backend/cosmetology-app/lambdas/nodejs/package.json`, `backend/cosmetology-app/lambdas/nodejs/tests/...`	Applied same branding change and test expectation updates; bumped `@types/nodemailer` metadata.
IAM SES Permissions `backend/compact-connect/stacks/persistent_stack/__init__.py`, `backend/cosmetology-app/stacks/persistent_stack/__init__.py`	Adjusted SES IAM policy conditions: compact-connect stack adds statements iterating allowed `ses:FromDisplayName` values (`"Compact Connect"`, `"CompactConnect"`) to support migration; cosmetology-app stack updated FromDisplayName to `CompactConnect`.
Python Dependency Pin Updates (CompactConnect) `backend/compact-connect/lambdas/python//requirements.txt`, `backend/compact-connect/requirements.in`, `backend/compact-connect/requirements*.txt`	Bumped boto3/botocore/cryptography/faker/pytest and other dev/runtime pins; updated pip-compile provenance comments and removed some explicit tzdata pins.
Python Dependency Pin Updates (Cosmetology App) `backend/cosmetology-app/lambdas/python//requirements.txt`, `backend/cosmetology-app/requirements.in`, `backend/cosmetology-app/requirements*.txt`	Bumped boto3/botocore/charset-normalizer/cryptography/faker/aws-lambda-powertools and related pins; updated provenance comments and removed some tzdata pins.
Docs & Misc Text `backend/compact-connect/README.md`, `backend/compact-connect/docs/`, `backend/cosmetology-app/README.md`, `backend/.../app_clients/`, `backend/.../docs/*`	Replaced occurrences of "Compact Connect" with "CompactConnect" in READMEs, onboarding/devops docs, and app client templates; no behavioral changes.
Python Code Formatting `backend/cosmetology-app/lambdas/python/common/cc_common/data_model/provider_record_util.py`	Reflowed a multi-line `logger.debug()` call into single-line formatting; no logic changes.
Tests Across Repos `backend/.../tests/lib/email/.test.ts`, `backend/.../tests/.test.ts`	Numerous test expectation string updates to reflect `CompactConnect` sender/subjects; no logic or input changes.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Feat/email mfa instructions #1108: Modifies the same email service source files and templates; overlaps with sender-string and template updates.
Privilege Expiry Email Notifications #1277: Touches base email service and notification templates; related to nodemailer/SES usage and template logic.
Fix/Migrate provider users pool to remove unneeded Cognito attributes #848: Adds/changes notification methods in email-notification-service.ts; affects same files updated here.

Suggested reviewers

jlkravitz
jusdino
isabeleliassen

Poem

"I’m a rabbit in the code, I nibbled one small space,
CompactConnect now hops proud across each email place.
Two policies watch the sender so migration stays polite,
Tests and deps aligned — I fixed it overnight. 🥕"

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description explains the requirements, the staged deployment strategy, and dependency updates, but does not follow the template structure with clearly defined Requirements/Description/Testing sections.	Reorganize the description to follow the template: clearly separate Requirements, Description, and Testing sections with checkboxes for verification steps.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly and concisely describes the main change: removing the space from the email display name ('Compact Connect' → 'CompactConnect').
Linked Issues check	✅ Passed	The PR addresses all primary coding requirements from issue `#1428`: removes space in email display names and updates IAM policy to support both formats during rollout.
Out of Scope Changes check	✅ Passed	All changes are within scope: email branding updates, policy changes, dependency version updates, and documentation changes directly support the issue objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

backend/cosmetology-app/stacks/persistent_stack/__init__.py (1)
372-372: Track removal of the legacy display-name permission with a concrete follow-up reference.

Line [372] has the right temporary TODO; adding an issue ID/target release in the comment would reduce risk of leaving legacy permission indefinitely.

If useful, I can draft a short follow-up issue template for the cleanup step.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@backend/cosmetology-app/stacks/persistent_stack/__init__.py` at line 372,
Update the TODO comment that reads 'Remove the "Compact Connect" display name
once all Lambda code exclusively uses "CompactConnect"' to include a concrete
follow-up reference (e.g., an issue/PR ID or target release and owner) so the
legacy display-name permission removal is tracked; locate the comment in
persistent_stack/__init__.py (the TODO mentioning "Compact
Connect"/"CompactConnect") and append the issue number or release milestone and
an owner/assignee and expected completion date.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@backend/compact-connect/lambdas/nodejs/package.json`:
- Line 52: Update the dev/prod dependency for the TypeScript definitions to
match nodemailer 8.x by changing the `@types/nodemailer` entry to ^8.0.0 in
package.json; locate the existing "nodemailer": "^8.0.5" and the pinned
"@types/nodemailer": "7.0.9" and update the latter to "^8.0.0", then run your
package manager install and rebuild to ensure types align with the nodemailer
8.x API.

---

Nitpick comments:
In `@backend/cosmetology-app/stacks/persistent_stack/__init__.py`:
- Line 372: Update the TODO comment that reads 'Remove the "Compact Connect"
display name once all Lambda code exclusively uses "CompactConnect"' to include
a concrete follow-up reference (e.g., an issue/PR ID or target release and
owner) so the legacy display-name permission removal is tracked; locate the
comment in persistent_stack/__init__.py (the TODO mentioning "Compact
Connect"/"CompactConnect") and append the issue number or release milestone and
an owner/assignee and expected completion date.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 94803ecd-c831-488a-b1f9-c351099251ef

📥 Commits

Reviewing files that changed from the base of the PR and between 3d8ed15 and 898b303.

⛔ Files ignored due to path filters (1)

backend/compact-connect/lambdas/nodejs/yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (55)

backend/compact-connect/lambdas/nodejs/lib/email/base-email-service.ts
backend/compact-connect/lambdas/nodejs/lib/email/email-notification-service.ts
backend/compact-connect/lambdas/nodejs/package.json
backend/compact-connect/lambdas/nodejs/tests/email-notification-service.test.ts
backend/compact-connect/lambdas/nodejs/tests/lib/email/email-notification-service.test.ts
backend/compact-connect/lambdas/nodejs/tests/lib/email/encumbrance-notification-service.test.ts
backend/compact-connect/lambdas/nodejs/tests/lib/email/ingest-event-email-service.test.ts
backend/compact-connect/lambdas/nodejs/tests/lib/email/investigation-notification-service.test.ts
backend/compact-connect/lambdas/python/cognito-backup/requirements-dev.txt
backend/compact-connect/lambdas/python/common/requirements-dev.in
backend/compact-connect/lambdas/python/common/requirements-dev.txt
backend/compact-connect/lambdas/python/common/requirements.txt
backend/compact-connect/lambdas/python/compact-configuration/requirements-dev.txt
backend/compact-connect/lambdas/python/custom-resources/requirements-dev.txt
backend/compact-connect/lambdas/python/data-events/requirements-dev.txt
backend/compact-connect/lambdas/python/disaster-recovery/requirements-dev.txt
backend/compact-connect/lambdas/python/provider-data-v1/requirements-dev.in
backend/compact-connect/lambdas/python/provider-data-v1/requirements-dev.txt
backend/compact-connect/lambdas/python/purchases/requirements-dev.in
backend/compact-connect/lambdas/python/purchases/requirements-dev.txt
backend/compact-connect/lambdas/python/search/requirements-dev.txt
backend/compact-connect/lambdas/python/staff-user-pre-token/requirements-dev.txt
backend/compact-connect/lambdas/python/staff-users/requirements-dev.in
backend/compact-connect/lambdas/python/staff-users/requirements-dev.txt
backend/compact-connect/requirements-dev.in
backend/compact-connect/requirements-dev.txt
backend/compact-connect/requirements.txt
backend/compact-connect/stacks/persistent_stack/__init__.py
backend/cosmetology-app/lambdas/nodejs/lib/email/base-email-service.ts
backend/cosmetology-app/lambdas/nodejs/package.json
backend/cosmetology-app/lambdas/nodejs/tests/email-notification-service.test.ts
backend/cosmetology-app/lambdas/nodejs/tests/lib/email/encumbrance-notification-service.test.ts
backend/cosmetology-app/lambdas/nodejs/tests/lib/email/ingest-event-email-service.test.ts
backend/cosmetology-app/lambdas/nodejs/tests/lib/email/investigation-notification-service.test.ts
backend/cosmetology-app/lambdas/python/cognito-backup/requirements-dev.txt
backend/cosmetology-app/lambdas/python/cognito-backup/requirements.txt
backend/cosmetology-app/lambdas/python/common/cc_common/data_model/provider_record_util.py
backend/cosmetology-app/lambdas/python/common/requirements-dev.in
backend/cosmetology-app/lambdas/python/common/requirements-dev.txt
backend/cosmetology-app/lambdas/python/common/requirements.txt
backend/cosmetology-app/lambdas/python/compact-configuration/requirements-dev.txt
backend/cosmetology-app/lambdas/python/custom-resources/requirements-dev.txt
backend/cosmetology-app/lambdas/python/data-events/requirements-dev.txt
backend/cosmetology-app/lambdas/python/disaster-recovery/requirements-dev.txt
backend/cosmetology-app/lambdas/python/provider-data-v1/requirements-dev.in
backend/cosmetology-app/lambdas/python/provider-data-v1/requirements-dev.txt
backend/cosmetology-app/lambdas/python/search/requirements-dev.txt
backend/cosmetology-app/lambdas/python/search/requirements.txt
backend/cosmetology-app/lambdas/python/staff-user-pre-token/requirements-dev.txt
backend/cosmetology-app/lambdas/python/staff-users/requirements-dev.in
backend/cosmetology-app/lambdas/python/staff-users/requirements-dev.txt
backend/cosmetology-app/requirements-dev.in
backend/cosmetology-app/requirements-dev.txt
backend/cosmetology-app/requirements.txt
backend/cosmetology-app/stacks/persistent_stack/__init__.py

This system is not live in prod yet, so we can perform a hard cut-over to the new name

ChiefStief

There are many more references to Compact Connect throughout the code base, most of them are internal so not super important but the couple that I think should be addressed are:

Thank you for integrating with Compact Connect! You have been designated as the IT professional who is able to handle
credentials for secure machine-to-machine authentication between your state and CompactConnect.

And the external facing readmes

ChiefStief

Looks good

landonshumway-ia · 2026-04-14T22:25:45Z

@jlkravitz This is ready for your review. Thanks

jlkravitz

@isabeleliassen This is good to merge!

landonshumway-ia added 4 commits April 13, 2026 17:14

Update IAM policy to allow sending from fixed displayName

3ec43bb

Update cosm python minor dep updates to latest

927c9a9

Update all fromEmailAddress references to remove space

423904a

Update jcc python requirements to latest

50a7049

landonshumway-ia force-pushed the fix/remove-email-subject-spaces branch from 5c75275 to 50a7049 Compare April 13, 2026 22:15

landonshumway-ia added 2 commits April 13, 2026 17:23

linter/formatter

b23fd78

Update Faker dev dep to latest

898b303

landonshumway-ia marked this pull request as ready for review April 13, 2026 22:32

coderabbitai Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread backend/compact-connect/lambdas/nodejs/package.json

landonshumway-ia added 3 commits April 14, 2026 09:26

PR feedback - update nodemailer types dep

343c920

remove additional policy from Cosmetology

2627ea5

This system is not live in prod yet, so we can perform a hard cut-over to the new name

formatting

4740776

landonshumway-ia requested a review from ChiefStief April 14, 2026 14:46

ChiefStief suggested changes Apr 14, 2026

View reviewed changes

Remove space in name in docs/email message

1be8ecc

landonshumway-ia requested a review from ChiefStief April 14, 2026 17:57

ChiefStief approved these changes Apr 14, 2026

View reviewed changes

landonshumway-ia requested a review from jlkravitz April 14, 2026 22:25

jlkravitz approved these changes Apr 15, 2026

View reviewed changes

isabeleliassen merged commit 57b80ce into csg-org:main Apr 15, 2026
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove space from email display name#1462

Remove space from email display name#1462
isabeleliassen merged 10 commits intocsg-org:mainfrom
InspiringApps:fix/remove-email-subject-spaces

landonshumway-ia commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

ChiefStief left a comment •

edited

Loading

Uh oh!

ChiefStief left a comment

Uh oh!

landonshumway-ia commented Apr 14, 2026

Uh oh!

jlkravitz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

landonshumway-ia commented Apr 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChiefStief left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChiefStief left a comment

Choose a reason for hiding this comment

Uh oh!

landonshumway-ia commented Apr 14, 2026

Uh oh!

jlkravitz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

landonshumway-ia commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

ChiefStief left a comment •

edited

Loading