json stringify with mixed-type variables and type assertions#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: json stringify with mixed-type variables and type assertions
Summary
JSON.stringify({ ... } as any)crashed at LLVM opt: theastype assertion wraps the object in aTypeAssertionNode, soarg.type === "type_assertion"instead of"object", bypassingstringifyObjectLiteraland falling through tostringifyNumber. That calledgenerateExpressionon the whole object, bitcast the struct pointer toi8*, then passed it asdoubletosprintf— a type mismatch thatopt -O2rejects.type_assertionnodes ingenerateStringifybefore dispatch, using a namedTypeAssertionNodecast (avoids phi node metadata loss from inlineas { ... }struct assertions); extractgenerateStringifyArg()helper.Test plan
json stringify inline object with mixed string and number variable valuespassesjson stringify inline object with type assertion does not crashpasses