fix(parser-native): restore trailing return in bare switch case bodies (#597)#602
Closed
fix(parser-native): restore trailing return in bare switch case bodies (#597)#602
Conversation
…ock-wrap unary_expression case body — restores trailing return dropped by bare-case iteration (#597)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #597 — the regression that blocked all stdlib additions past 8 count. Unblocks #585 (net TCP module) and every future stdlib registration.
User-facing effect
Root cause
Parser-native's switch_case iteration was silently dropping the trailing `return` statement when a bare case body had the shape `[lexical_declaration, if_no_else, return]`. Tree-sitter reports fewer `namedChildCount` siblings than expected for this specific pattern, so the loop at `transformer.ts:2297` never visits the final `return`. The case body ended up as `[var_decl, if_no_else]` — no path returns — and `checkMissingReturns` correctly flagged it.
Only `case "unary_expression":` at `transformer.ts:528` had this 3-statement bare shape in the compiler source, so it was the lone trigger. Other bare case bodies had at most 2 statements (`[var_decl, return]`) and weren't affected.
Fix (two parts)
Followup
Test plan