Skip to content

refactor(codegen): delete dead resolveExpressionType public passthrough on LLVMGenerator#596

Merged
cs01 merged 1 commit intomainfrom
refactor/typeof-drop-dead-passthrough
Apr 20, 2026
Merged

refactor(codegen): delete dead resolveExpressionType public passthrough on LLVMGenerator#596
cs01 merged 1 commit intomainfrom
refactor/typeof-drop-dead-passthrough

Conversation

@cs01
Copy link
Copy Markdown
Owner

@cs01 cs01 commented Apr 20, 2026

Summary

  • Deletes the public resolveExpressionType(expr) passthrough on LLVMGenerator (was llvm-generator.ts:4246-4248). After refactor(codegen): migrate member.ts to typeOf() #594 migrated the last external consumer (member.ts), this method had zero callers.
  • resolveExpressionTypeRich passthrough stays — it's the TypeAnnotatorSink method the pre-codegen annotator calls to fill the typeOf cache.

User-facing effect

  • No behavior change. Shrinks the LLVMGenerator public API surface. One fewer way to bypass the canonical typeOf() lookup.

Part of Phase-E convergence

Test plan

  • npm run verify — full tests + 3-stage self-host green locally
  • CI green

…gh on llvmgenerator — no external consumers after member.ts migration
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Results (Linux x86-64)

Benchmark C ChadScript Go Node Place
Cold Start 1.3ms 0.9ms 1.3ms 29.4ms 🥇
Fibonacci 0.818s 0.764s 1.563s 3.181s 🥇
File I/O 0.119s 0.090s 0.091s 0.209s 🥇
Hash Map Lookup 0.097s 0.063s 0.091s 0.113s 🥇
Binary Trees 1.388s 1.297s 2.745s 1.182s 🥈
JSON Parse/Stringify 0.035s 0.051s 0.172s 0.135s 🥈
N-Body Simulation 1.668s 2.120s 2.205s 2.379s 🥈
Regex Match 0.016s 0.005s 0.021s 0.004s 🥈
SQLite 0.051s 0.371s 0.496s 0.492s 🥈
Monte Carlo Pi 0.389s 0.410s 0.405s 2.248s 🥉
Quicksort 0.214s 0.248s 0.213s 0.263s 🥉
Sieve of Eratosthenes 0.016s 0.029s 0.021s 0.038s 🥉
String Manipulation 0.008s 0.019s 0.016s 0.037s 🥉
Matrix Multiply 0.444s 0.716s 0.578s 0.486s #4

CLI Tool Benchmarks

Benchmark ChadScript grep node xxd Place
Hex Dump 0.557s 1.001s 0.132s 🥈
Recursive Grep 0.020s 0.010s 0.102s 🥈

@cs01 cs01 merged commit 0199152 into main Apr 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant