buckets: make a copy of all event maps before pouring the event to a bucket#4481
buckets: make a copy of all event maps before pouring the event to a bucket#4481blotus wants to merge 2 commits into
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4481 +/- ##
==========================================
+ Coverage 63.88% 63.89% +0.01%
==========================================
Files 478 478
Lines 34298 34307 +9
==========================================
+ Hits 21911 21921 +10
+ Misses 10231 10228 -3
- Partials 2156 2158 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #4459.
This introduces additional allocations each time we pour an item to a bucket, but there's probably no way around this: the maps must be owned by each buckets.
As a side-effect, this also fixes a potential race conditions in the meta:
evt.SetMeta