downgrade github.com/mattn/go-sqlite3 to v1.14.32#4473
Conversation
|
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
==========================================
- Coverage 63.89% 63.88% -0.02%
==========================================
Files 478 478
Lines 34298 34298
==========================================
- Hits 21915 21911 -4
- Misses 10227 10231 +4
Partials 2156 2156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Cool, this matches what I found in #4471 (comment) - will run some benchmarks on my database and report back in the #4464 issue thread. |
|
/kind fix |
Should fix the underlying regression for #4470 and #4464 (in addition to #4471 which does seem to help).
After investigation, the regression came from the update of github.com/mattn/go-sqlite3 from
v1.14.23to1.14.44(in this PR #4453 for the final update).After testing the various releases of the go library, it seems the regression was introduced in
v1.14.33.I'm not sure what the regression is exactly (claude points to this commit, but I didn't looked at it in details).
So for now, let's just downgrade sqlite to get back to the performance we had before the release, and we will also improve the queries themselves (with at least #4471, and I've also identified potential gains in the way we perform the pagination for
/v1/alerts, but that will come later)