Skip to content

downgrade github.com/mattn/go-sqlite3 to v1.14.32#4473

Merged
blotus merged 1 commit into
masterfrom
sqlite-dowgrade-1.14.32
May 19, 2026
Merged

downgrade github.com/mattn/go-sqlite3 to v1.14.32#4473
blotus merged 1 commit into
masterfrom
sqlite-dowgrade-1.14.32

Conversation

@blotus
Copy link
Copy Markdown
Member

@blotus blotus commented May 18, 2026

Should fix the underlying regression for #4470 and #4464 (in addition to #4471 which does seem to help).

After investigation, the regression came from the update of github.com/mattn/go-sqlite3 from v1.14.23 to 1.14.44 (in this PR #4453 for the final update).

After testing the various releases of the go library, it seems the regression was introduced in v1.14.33.

I'm not sure what the regression is exactly (claude points to this commit, but I didn't looked at it in details).

So for now, let's just downgrade sqlite to get back to the performance we had before the release, and we will also improve the queries themselves (with at least #4471, and I've also identified potential gains in the way we perform the pagination for /v1/alerts, but that will come later)

@github-actions
Copy link
Copy Markdown

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link
Copy Markdown

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.88%. Comparing base (b4b2de2) to head (1e0241e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4473      +/-   ##
==========================================
- Coverage   63.89%   63.88%   -0.02%     
==========================================
  Files         478      478              
  Lines       34298    34298              
==========================================
- Hits        21915    21911       -4     
- Misses      10227    10231       +4     
  Partials     2156     2156              
Flag Coverage Δ
bats 46.45% <ø> (ø)
unit-linux 37.33% <ø> (+<0.01%) ⬆️
unit-windows 25.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimstrang
Copy link
Copy Markdown

Cool, this matches what I found in #4471 (comment) - will run some benchmarks on my database and report back in the #4464 issue thread.

@blotus
Copy link
Copy Markdown
Member Author

blotus commented May 19, 2026

/kind fix

@blotus blotus merged commit baa39fb into master May 19, 2026
16 checks passed
@blotus blotus deleted the sqlite-dowgrade-1.14.32 branch May 19, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants