Skip to content

feat(bundles): add request body and export settings to Export Bundle #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrii-bodnar merged 1 commit into from
Aug 3, 2026
Merged

feat(bundles): add request body and export settings to Export Bundle #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion crowdin_api/api_resources/bundles/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,17 @@ def download_bundle(
path=f"{self.get_bundles_exports_path(projectId=projectId, bundleId=bundleId, exportId=exportId)}/download",
)

def export_bundle(self, bundleId: int, projectId: Optional[int] = None):
def export_bundle(
self,
bundleId: int,
projectId: Optional[int] = None,
targetLanguageIds: Optional[Iterable[str]] = None,
skipUntranslatedStrings: Optional[bool] = None,
skipUntranslatedFiles: Optional[bool] = None,
exportApprovedOnly: Optional[bool] = None,
exportWithMinApprovalsCount: Optional[int] = None,
exportStringsThatPassedWorkflow: Optional[bool] = None,
):
"""
Export bundle.

Expand All @@ -188,6 +198,14 @@ def export_bundle(self, bundleId: int, projectId: Optional[int] = None):
return self.requester.request(
method="post",
path=self.get_bundles_exports_path(projectId=projectId, bundleId=bundleId),
request_data={
"targetLanguageIds": targetLanguageIds,
"skipUntranslatedStrings": skipUntranslatedStrings,
"skipUntranslatedFiles": skipUntranslatedFiles,
"exportApprovedOnly": exportApprovedOnly,
"exportWithMinApprovalsCount": exportWithMinApprovalsCount,
"exportStringsThatPassedWorkflow": exportStringsThatPassedWorkflow,
},
)

def check_bundle_export_status(
Expand Down
42 changes: 39 additions & 3 deletions crowdin_api/api_resources/bundles/tests/test_bundles_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,50 @@ def test_download_bundle(self, m_request, base_absolut_url):
method="get", path=f"{resource.get_bundles_exports_path(projectId=1, bundleId=1, exportId='1')}/download"
)

@pytest.mark.parametrize(
"incoming_data, request_data",
(
(
{},
{
"targetLanguageIds": None,
"skipUntranslatedStrings": None,
"skipUntranslatedFiles": None,
"exportApprovedOnly": None,
"exportWithMinApprovalsCount": None,
"exportStringsThatPassedWorkflow": None,
},
),
(
{
"targetLanguageIds": ["uk", "de"],
"skipUntranslatedStrings": True,
"skipUntranslatedFiles": False,
"exportApprovedOnly": True,
"exportWithMinApprovalsCount": 2,
"exportStringsThatPassedWorkflow": True,
},
{
"targetLanguageIds": ["uk", "de"],
"skipUntranslatedStrings": True,
"skipUntranslatedFiles": False,
"exportApprovedOnly": True,
"exportWithMinApprovalsCount": 2,
"exportStringsThatPassedWorkflow": True,
},
),
),
)
@mock.patch("crowdin_api.requester.APIRequester.request")
def test_export_bundle(self, m_request, base_absolut_url):
def test_export_bundle(self, m_request, incoming_data, request_data, base_absolut_url):
m_request.return_value = "response"

resource = self.get_resource(base_absolut_url)
assert resource.export_bundle(projectId=1, bundleId=1) == "response"
assert resource.export_bundle(projectId=1, bundleId=1, **incoming_data) == "response"
m_request.assert_called_once_with(
method="post", path=resource.get_bundles_exports_path(projectId=1, bundleId=1)
method="post",
path=resource.get_bundles_exports_path(projectId=1, bundleId=1),
request_data=request_data,
)

@mock.patch("crowdin_api.requester.APIRequester.request")
Expand Down
Loading