Skip to content

Conversation

@imprvhub
Copy link
Contributor

This commit implements API endpoint to list strings on workflow steps with full test coverage:

  • Add list_workflow_step_strings method with query parameters support
  • Implement path helper get_workflow_step_strings_path
  • Add parameterized tests covering basic usage, full parameters and edge cases
  • Add mock tests for API request validation
  • Ensure all test cases follow existing patterns in the codebase
  • Follow Crowdin Enterprise API specification

Closes #184

imprvhub and others added 2 commits November 27, 2024 23:47
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
This commit implements API endpoint to list strings on workflow steps with full test coverage:

- Add list_workflow_step_strings method with query parameters support
- Implement path helper get_workflow_step_strings_path
- Add parameterized tests covering basic usage, full parameters and edge cases
- Add mock tests for API request validation
- Ensure all test cases follow existing patterns in the codebase
- Follow Crowdin Enterprise API specification

Closes crowdin#184
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (1fa4b5b) to head (f84ded2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   99.21%   99.21%   +0.01%     
==========================================
  Files         166      166              
  Lines        6505     6519      +14     
  Branches      149      149              
==========================================
+ Hits         6453     6467      +14     
  Misses         36       36              
  Partials       16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar changed the title feat(api): add List Strings on Workflow Step method (#184) feat(api): add List Strings on Workflow Step method Nov 28, 2024
This commit implements API endpoint to list strings on workflow steps with full test coverage:

Add list_workflow_step_strings method with query parameters support
Implement path helper get_workflow_step_strings_path
Add parameterized tests covering basic usage, full parameters and edge cases
Add mock tests for API request validation
Ensure all test cases follow existing patterns in the codebase
Follow Crowdin Enterprise API specification

Closes crowdin#184
@imprvhub
Copy link
Contributor Author

imprvhub commented Nov 28, 2024

@andrii-bodnar I removed those whitespace lines specifically because they were causing flake8 validation errors. The linter was reporting W293 (blank line contains whitespace) on lines 40, 74, and 91. By removing these whitespaces, we ensure the code passes all quality checks while maintaining functionality. This change was not arbitrary but necessary for code quality compliance.

@andrii-bodnar
Copy link
Member

@imprvhub hmm, it's interesting why it didn't fail before. Probably the rules have changed over time and it only fails on updated files or something. Ok, let's make it follow the validation rules.

This commit implements API endpoint to list strings on workflow steps with full test coverage:

-Add list_workflow_step_strings method with query parameters support
-Implement path helper get_workflow_step_strings_path
-Add parameterized tests covering basic usage, full parameters and edge cases
-Add mock tests for API request validation
-Ensure all test cases follow existing patterns in the codebase
-Follow Crowdin Enterprise API specification

Closes crowdin#184
@imprvhub
Copy link
Contributor Author

@andrii-bodnar Done!.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imprvhub thank you for the contribution!

@andrii-bodnar andrii-bodnar merged commit 21f1fa3 into crowdin:main Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflows API: new List Strings on the Workflow Step method

3 participants