-
Notifications
You must be signed in to change notification settings - Fork 39
feat(api): add List Strings on Workflow Step method #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add List Strings on Workflow Step method #186
Conversation
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
This commit implements API endpoint to list strings on workflow steps with full test coverage: - Add list_workflow_step_strings method with query parameters support - Implement path helper get_workflow_step_strings_path - Add parameterized tests covering basic usage, full parameters and edge cases - Add mock tests for API request validation - Ensure all test cases follow existing patterns in the codebase - Follow Crowdin Enterprise API specification Closes crowdin#184
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 99.21% 99.21% +0.01%
==========================================
Files 166 166
Lines 6505 6519 +14
Branches 149 149
==========================================
+ Hits 6453 6467 +14
Misses 36 36
Partials 16 16 ☔ View full report in Codecov by Sentry. |
This commit implements API endpoint to list strings on workflow steps with full test coverage: Add list_workflow_step_strings method with query parameters support Implement path helper get_workflow_step_strings_path Add parameterized tests covering basic usage, full parameters and edge cases Add mock tests for API request validation Ensure all test cases follow existing patterns in the codebase Follow Crowdin Enterprise API specification Closes crowdin#184
|
@andrii-bodnar I removed those whitespace lines specifically because they were causing flake8 validation errors. The linter was reporting W293 (blank line contains whitespace) on lines 40, 74, and 91. By removing these whitespaces, we ensure the code passes all quality checks while maintaining functionality. This change was not arbitrary but necessary for code quality compliance. |
|
@imprvhub hmm, it's interesting why it didn't fail before. Probably the rules have changed over time and it only fails on updated files or something. Ok, let's make it follow the validation rules. |
This commit implements API endpoint to list strings on workflow steps with full test coverage: -Add list_workflow_step_strings method with query parameters support -Implement path helper get_workflow_step_strings_path -Add parameterized tests covering basic usage, full parameters and edge cases -Add mock tests for API request validation -Ensure all test cases follow existing patterns in the codebase -Follow Crowdin Enterprise API specification Closes crowdin#184
|
@andrii-bodnar Done!. |
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imprvhub thank you for the contribution!
This commit implements API endpoint to list strings on workflow steps with full test coverage:
Closes #184