Repository navigation
fix: deserialize empty array FileInfo.fields as null - #436
Merged
andrii-bodnar merged 1 commit intoNov 11, 2026
Merged
Conversation
The Enterprise API returns "fields": [] for files without custom fields, which failed to deserialize into Map<String, Object>. Reuse EmptyArrayToNullDeserializer, as other Map fields already do. Fixes crowdin#435
andrii-bodnar
approved these changes
Nov 11, 2026
andrii-bodnar
left a comment
andrii-bodnar
left a comment
Member
There was a problem hiding this comment.
@Mithilbatra thank you!
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435
When a file has no custom fields, the Crowdin Enterprise API returns
"fields": []. Deserializing that intoFileInfo.fields(Map<String, Object>) threw aMismatchedInputException.This reuses the existing
EmptyArrayToNullDeserializeron the field, like the otherMapfields that get[]from the API (Webhook.headers,ExternalQaCheck.config,ProjectSettings.assignedTms, ...).FileextendsFileInfo, so both response shapes are covered.Testing
"fields": []to thelistFileInfos.jsonfixture and an assertion inSourceFilesApiTest.listFileInfosTest. The test fails with the exception from the issue before the fix and passes after it../gradlew buildpasses.