Repository navigation
[Backport release-2.4] render: Don't try to start non-functions as functions - #421
Merged
Merged
Conversation
Previously, render tried to start all runtime xpkg dependencies as functions, including providers. This didn't cause any problems (the providers sat running, doing nothing), but was wasteful and increased the chance of render timing out while pulling packages. Explicitly check the kind of each dependency and skip any that are not functions. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io> (cherry picked from commit 7e7d2fa)
github-actions
Bot
requested review from
a team,
jcogilvie and
tampakrap
as code owners
October 13, 2026 13:18
github-actions
Bot
requested review from
jbw976
and removed request for
a team
October 13, 2026 13:18
3 tasks done
adamwg
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #419 to
release-2.4.