Add integration for Drupal#1
Open
marcospassos wants to merge 4 commits into
Open
Conversation
Fryuni
approved these changes
Jun 6, 2026
renan628
approved these changes
Jun 8, 2026
denis-rossati
approved these changes
Jun 8, 2026
denis-rossati
approved these changes
Jun 9, 2026
Replace the local `path` repositories for croct/plug-php and croct/plug-symfony with `vcs` repositories pointing at their GitHub repos, so CI can resolve `dev-initial-version` / `dev-initial-implementation` from the pushed branches instead of sibling directories that only exist locally. The path repos broke `composer install` in the composer, test, validate, and lint jobs, and left the committed lock incompatible with composer.json. Regenerate the lock against the git sources. Resolving plug-symfony via vcs additionally required correcting the package name on the symfony-bundle-php master branch (done separately), since Composer derives a repository's package name from its default branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fryuni
approved these changes
Jun 10, 2026
Comment on lines
+23
to
+25
| if ($response instanceof CacheableResponseInterface) { | ||
| $response->getCacheableMetadata()->addCacheContexts(['session']); | ||
| } |
Member
There was a problem hiding this comment.
[NOTE] Won't this still allow (even if not enforce, depends on surrounding config) Drupal to cache the request for the user so subsequent fetches to the same slot might not get updated with new event information?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drupal integration is a thin layer on top of the Symfony integation.
Checklist