Repository navigation
cleanup - #303
Merged
Merged
cleanup#303
Conversation
davidabram
added this pull request to stack #302
October 8, 2026 13:53
davidabram
force-pushed
the
dead-code-blues
branch
3 times, most recently
from
October 8, 2026 15:02
583c49d to
c744148
Compare
davidabram
removed this pull request from stack #302
October 10, 2026 08:24
davidabram
added this pull request to stack #312
October 10, 2026 08:24
Define the PR3 dead-code cleanup, reconciliation disposition gate, async simplification, blocking and future-size audits, and final validation workflow. Preserve the diff-trace compatibility surface while deferring ref reconciliation until an explicit decision is recorded. Plan: cli-async-persistence-cleanup-pr3 Tasks: T01, T02, T03, T04, T05, T06 Co-authored-by: SCE <sce@crocoder.dev>
Record the authoritative PR2 dead-code baseline, diagnostic counts, symbol-level classifications, and reconciliation dependency analysis completed for T01. Preserve the evidence and follow-up dispositions needed by the remaining cleanup tasks. Plan: cli-async-persistence-cleanup-pr3, T01 Co-authored-by: SCE <sce@crocoder.dev>
Delete the T02-classified unused CLI APIs, wrappers, fixtures, tests, and broad dead-code allowances while preserving live runtime behavior and retained compatibility surfaces. Refresh the affected service contracts and completion record with the resulting API and verification state. Plan: cli-async-persistence-cleanup-pr3 (T02) Co-authored-by: SCE <sce@crocoder.dev>
Add staged patch histories and expected trace documents for agent-trace reconstruction scenarios. Exercise file lifecycle, renames, mixed changes, and poem fixtures through shared golden-output assertions. Co-authored-by: SCE <sce@crocoder.dev>
The async-persistence cleanup keeps ref reconciliation available for future wiring without leaving a module-wide dead-code suppression. Scope allowances to the reconciliation dependency cluster and document the retained-but-unwired status, including orphaned pin accumulation; remove the unused worktree lock path. Plan: cli-async-persistence-cleanup-pr3, T03 Co-authored-by: SCE <sce@crocoder.dev>
Simplify post-async persistence code by deleting the unused synchronous retry variant and flattening forwarding async blocks in database migration and sync services. Retain the distinct cancelling and non-cancelling async retry semantics, and preserve the hand-rolled concurrent join behavior that protects in-flight completion and credential persistence. Update the glossary and resilience patterns to document the current retry API and record completion of T04 in the async persistence cleanup plan. Plan: cli-async-persistence-cleanup-pr3 (T04) Co-authored-by: SCE <sce@crocoder.dev>
Complete plan T05 by documenting the retained blocking sites, measured future sizes, recursion-limit decision, temporary-index cleanup limitation, and platform-specific guarded-shell descriptor race. The audit found no safe code reduction or sweeper protocol, so the known limitations and follow-up boundaries are recorded without changing CLI behavior. Ref: context/plans/cli-async-persistence-cleanup-pr3.md#t05 Co-authored-by: SCE <sce@crocoder.dev>
Document the completed post-migration cleanup audit, including removed dead code, retained declaration-level exceptions, measured diagnostic and LOC deltas, and Linux-only limitations. Update the related context map, overview, pattern guidance, and stale runtime-test references so the durable documentation matches the cleaned implementation. Record the completed T06 evidence and defer the full repository checks to the plan's final validation gate. Ref: context/plans/cli-async-persistence-cleanup-pr3.md#T06 Co-authored-by: SCE <sce@crocoder.dev>
Require the remote state response to include a valid diff-traces cursor, keep the zero-upload diff-traces stream in JSON reports, and verify that sync uploads only messages, parts, and agent traces. Generalize sync helpers over credential stores so these contracts can be exercised with deterministic control-plane fixtures. Ref: context/plans/cli-async-persistence-cleanup-pr3.md (AC1–AC12) Co-authored-by: SCE <sce@crocoder.dev>
davidabram
force-pushed
the
dead-code-blues
branch
from
October 10, 2026 11:49
d90415e to
6de9ddc
Compare
Co-authored-by: SCE <sce@crocoder.dev>
davidabram
removed this pull request from stack #312
October 10, 2026 22:50
davidabram
added this pull request to stack #320
October 10, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.