Repository navigation
single tokio runtime - #300
Merged
Merged
Conversation
Document the staged migration to one application Tokio runtime while retaining synchronous lifecycle providers and the temporary Turso adapter. Cover the atomic app, auth, sync, credential-isolation, regression-test, and durable-context work needed to preserve existing CLI contracts and concurrency behavior. Ref: context/plans/cli-single-tokio-runtime-pr1.md (T01, T02, T03, T04, T05) Co-authored-by: SCE <sce@crocoder.dev>
Clarify the application-level runtime boundary, classify the narrowly justified database blocking scopes, and preserve the retained Turso bridge until PR2. Tighten async telemetry, resource-lifetime, test-boundary, packaging-validation, architecture, and acceptance guidance without implementing the migration. Ref: context/plans/cli-single-tokio-runtime-pr1.md (T01, T02, T03, T04, T05) Co-authored-by: SCE <sce@crocoder.dev>
Document that future telemetry must follow command future polling across multi-thread Tokio workers rather than hold thread-local tracing guards across `.await`. Tie T04 validation to future-aware subscriber attachment or intentional global installation while keeping PR1 NoopTelemetry unchanged. Plan: cli-single-tokio-runtime-pr1 (T04) Co-authored-by: SCE <sce@crocoder.dev>
Enable Tokio macros and the multi-thread runtime while retaining disabled default features and existing runtime support, preparing the application migration without changing the synchronous entrypoint or current-thread ownership in auth, sync, and Turso. Refresh the lockfile and Flatpak source metadata for tokio-macros and syn 3.0.6. Plan: cli-single-tokio-runtime-pr1 (T01) Co-authored-by: SCE <sce@crocoder.dev>
Activate one application-level multi-thread Tokio runtime for static command dispatch, auth, and sync instead of constructing command-local runtimes. Preserve synchronous Turso ownership with scoped blocking cleanup, and use awaited owned blocking closures for credential operations. Update the runtime, capability, observability, sync, and command documentation to record the borrowing, telemetry, cleanup, and retained persistence boundaries. Complete T02 with focused build and auth/sync test evidence while leaving the PR2 persistence migration for follow-up. Plan: `context/plans/cli-single-tokio-runtime-pr1.md` Task: `T02` Co-authored-by: SCE <sce@crocoder.dev>
Route auth credential load, save, and delete calls through one blocking-operation helper that preserves typed storage and worker-failure errors. Add multi-thread async regressions for dispatch, renewal fallback, credential isolation, and control-plane load/save behavior. Plan: `cli-single-tokio-runtime-pr1` — T03 Co-authored-by: SCE <sce@crocoder.dev>
Add multi-thread lifecycle, telemetry-polling, output, hook-persistence, and sync-storage cleanup regressions at the real async command boundary. The tests preserve existing CLI contracts while covering awaited dispatch, repeat protection, and cleanup when work errors or is abandoned. Plan: cli-single-tokio-runtime-pr1.md (T04) Co-authored-by: SCE <sce@crocoder.dev>
Record the completed PR1 application-level Tokio runtime and static command dispatch across the architecture and CLI contract owners. Describe direct Auth/Sync awaits, the justified DB lifetime scopes, sync storage cleanup, retained Turso bridge, and the future PR2 async-Turso boundary while correcting ownership and telemetry annotations. Complete plan `cli-single-tokio-runtime-pr1`, task T05, with the final runtime documentation and verification record. Co-authored-by: SCE <sce@crocoder.dev>
davidabram
force-pushed
the
single-tokio-runtime
branch
from
October 7, 2026 11:49
43ff3aa to
c9306dc
Compare
davidabram
added this pull request to stack #302
October 7, 2026 13:39
davidabram
removed this pull request from stack #302
October 10, 2026 08:24
davidabram
added this pull request to stack #312
October 10, 2026 08:24
davidabram
removed this pull request from stack #312
October 10, 2026 22:50
davidabram
added this pull request to stack #324
October 11, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.