Add bedrock model ID fallback#817
Open
hschne wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 81.38% 81.42% +0.04%
==========================================
Files 165 165
Lines 7361 7361
Branches 1220 1220
==========================================
+ Hits 5991 5994 +3
+ Misses 875 874 -1
+ Partials 495 493 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fix Bedrock Converse non-streaming responses so
Message#model_idfalls back to the request model when Bedrock omitsmodelId.Why
Bedrock Converse responses do not include
modelId, so non-streaming messages currently getmodel_id: nil. That preventsMessage#costfrom resolving pricing, even though the request model is known. Streaming already falls back to@model.id; this makes non-streaming match that behavior.Reproduction
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes