fix: properly read namespaces with no prefix from the root element#626
Open
Unix4ever wants to merge 1 commit intocrewjam:mainfrom
Open
fix: properly read namespaces with no prefix from the root element#626Unix4ever wants to merge 1 commit intocrewjam:mainfrom
Unix4ever wants to merge 1 commit intocrewjam:mainfrom
Conversation
Another attempt to fix: crewjam#580 The code is reading the attributes from the elements in the loop, then writes to a map using `chileEl.Scope` as the key. Intention behind this code is not clear, as the map contains a random string for an empty space, depending which element was the last one. Instead, write the key to the map only if the `childEl` is the element we're encoding. Tested that against Fusion Auth SAML and Microsoft SP with SAML. Can't submit the ACS/Metadata for Microsoft for the testing purposes, as it contains the sensitive data. Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Author
|
@crewjam any comments, feedback, suggestions on this PR? Can we please get it merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt to fix: #580
The code is reading the attributes from the elements in the loop, then writes to a map using
childEl.Scopeas the key. Intention behind this code is not clear, as the resulting map contains a random string for an empty space, depending on which element was the last one.Instead, write the key to the map only if the
childElis the element we're encoding.Tested that against Fusion Auth SAML and Microsoft SP with SAML. Can't submit the ACS/Metadata for Microsoft for the testing purposes, as it contains the sensitive data.