Add comprehensive tests for MCP imports to address issue #3858 #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comprehensive tests that verify the fix for issue #3858, where users reported ModuleNotFoundError when trying to import MCP classes from crewai.mcp. The issue was resolved in version 1.4.0 with the addition of first-class MCP support (commit 6f36d70). These tests ensure: 1. MCPServerStdio, MCPServerHTTP, and MCPServerSSE can be imported from crewai.mcp 2. Agent accepts mcps parameter with these configuration classes 3. The exact documentation example from issue #3858 works correctly 4. All MCP server configs are proper Pydantic models with validation 5. Optional fields work as expected All 10 new tests pass, and existing MCP tests continue to pass. Fixes #3858 Co-Authored-By: João <joao@crewai.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive tests for MCP imports to address issue #3858
Summary
This PR adds comprehensive test coverage for the MCP import functionality that was added in version 1.4.0 to resolve issue #3858. The issue reported that users on version 1.3.0 could not import
MCPServerStdio,MCPServerHTTP, andMCPServerSSEfromcrewai.mcpas shown in the documentation.The fix was already implemented in commit 6f36d70 (feat: first-class MCP support), but lacked specific tests that replicate the exact failing code from the issue. This PR adds 10 new tests that:
crewai.mcpwithout errorsmcpsparameter with these configurationsAll 10 new tests pass ✅, and all 5 existing MCP tests continue to pass ✅.
Review & Testing Checklist for Human
Test Plan
Notes
Fixes #3858