Fix missing and stale Monet wallpaper colors - #1347
Open
pbzin wants to merge 1004 commits into
Open
Conversation
Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
If proc is null, other threads may remain in the “Waiting” state indefinitely within the handleApplicationStrictModeViolation method. Test: monkey test Flag: EXEMPT bugfix Bug: 494493385 Change-Id: Ideb98538203f5d0855300424e9aae54358d19a76 Signed-off-by: luanzhuang <luanzhuang@xiaomi.corp-partner.google.com>
bug:494502685 direct byte buffer was not released, causing a memory leak. Change-Id: Ida8e32589d666901517c4e4eb537748addb213d5 Signed-off-by: Aiguo <aiguo.feng@amlogic.corp-partner.google.com>
Design Concept attribution: BlissRoms/platform_frameworks_base@d7be9f3 BlissRoms/platform_frameworks_base@7a8a026 BlissRoms/platform_frameworks_base@a50e10c Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* Treat classic tiles as icon only so that we apply color and bounceable animation correctly. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Ref: https://github.com/BootleggersROM/packages_overlays_Shishufied/tree/queso/QSTiles * Regenerate path and adapt for our implementation. * Add separate outline tile color to make it distinct. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
[neobuddy89: Do not change style, only weight] Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Keep the discrete steps but hide the visual tick marks for a more cleaner look. Change-Id: I3585f62d0126afb00223104192a4cedfcdf13cbe Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Treat empty attribution tags the same way as null in isAttributionInPackage(). This avoids repeated AppOps error logs from pre-S apps that pass an empty string attribution tag even though they could not declare <attribution> entries in their manifest. Change-Id: Ieecdba9130328ab9de3c1e16d9b2100b288ce492 Signed-off-by: Quince <quinceroms@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Only log and start IME hide tracking when the IME is actually requested visible or when a user-controlled IME animation is active. This avoids repeated hide(ime()) log spam and unnecessary ImeTracker token allocation when clients keep asking to hide an already hidden IME. Change-Id: Iff27ec1b4c7c8236346c18996b776f34612c8975 Signed-off-by: Quince <quinceroms@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Remove the delayed dismiss message when LogAccessDialogActivity is destroyed and guard the final dialog dismiss in onClick(). This prevents stale timeout callbacks from interacting with a detached DecorView after configuration changes. Change-Id: Ib8abe68cb4c7aa95dd90b9c67d1b6ac7cd3706b3 Signed-off-by: Quince <quinceroms@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I64d455835389acb2e591ff0b623797e1e122f06d Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
During USB headset disconnection, AudioDeviceBroker synchronously restores mBluetoothA2dpEnabled=true, but mGlobalBluetoothA2dpOn in MediaRouterService is only updated later via the asynchronous dispatchAudioRoutesChanged callback. A playback state change in this transient window causes restoreBluetoothA2dp() to read the stale mGlobalBluetoothA2dpOn=false and call setBluetoothA2dpOn(false), overriding the already-restored A2DP state and suppressing Bluetooth audio output. Fix by cross-checking with AudioService.isBluetoothA2dpOn() before setting A2DP off. When the two states are inconsistent (local says off but AudioService says on), skip the stale request. Bug: 498786084 Test: 1. Connect Bluetooth headphones and play music. 2. Plug in USB headphones. 3. Unplug USB headphones. Flag: EXEMPT bug fix Change-Id: I98a64166f0f130347cb90cebf362c6d1a9935024 Signed-off-by: chenxin20 <chenxin20@xiaomi.com>
…in scenarios involving dual instances of the app. Perform a backup for each user. Test: atest Bug:498471068 Change-Id: Ib3cd2fbd58a8039a9c0a598e9d6346ff3b00e01c Signed-off-by: luanzhuang <luanzhuang@xiaomi.corp-partner.google.com>
… for lock screen unlocking Bug: 499150034 Test: 1. Set PIN unlock method 2. Lock it and press the unlock button 3. Intentionally enter the wrong password and wait for the countdown. 4. During the countdown, repeatedly open and close the unlock disc 5. Check if the countdown is correct Change-Id: I7c15a95a7871a04ec0a71f5405be2d014aadfe45
Change-Id: I2aaa9e526b6f1a35d45e96b6d23e3db972d82733 Signed-off-by: Joey Huab <joey@evolution-x.org> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
A leak can occur for any app that uses StrictMode#enableDefaults or sets
StrictMode.VmPolicy.Builder's detectBlockedBackgroundActivityLaunch or detectAll. If any of those
are called or set, every call to StrictMode#setVmPolicy (this is used in core framework code like
LoadedApk) will trigger StrictMode#registerBackgroundActivityLaunchCallback. This registers a brand
new callback every time.
In system_server, these new callbacks are just stored in an ArrayMap in
BackgroundActivityStartController's addStrictModeCallback which uses the IBinder as the map key.
Since every new BackgroundActivityLaunchCallback is a distinct IBinder, containsKey(callback) never
returns true for a new callback instance from StrictMode.
For userdebug/eng builds, this leak can also occur in any bundled system app due to the logic in
StrictMode#initVmDefaults. In particular, SystemUI can crash because of this leak. When such a crash
occurs, the following is printed out (UID 10126 is SystemUI):
V Binder : BinderProxy descriptor histogram (top 10):
V Binder : # 1: android.app.IBackgroundActivityLaunchCallback x5698
V Binder : # 2: android.content.IIntentReceiver x471
V Binder : # 3: android.content.IContentProvider x304
V Binder : # 4: android.database.IContentObserver x237
V Binder : # 5: android.app.IApplicationThread x140
V Binder : # 6: com.android.internal.os.IResultReceiver x135
V Binder : # 7: android.app.IUnsafeIntentStrictModeCallback x92
V Binder : # 8: x86
V Binder : # 9: <cleared weak-ref> x83
V Binder : # 10: <proxy to dead node> x54
D Binder : Per Uid Binder Proxy Counts:
...
D Binder : UID : 10126 count = 6006
...
E BpBinder: Too many binder proxy objects sent to uid 1000 from uid 10126 (... proxies held)
E ActivityManager: Uid 10126 sent too many Binders to uid 1000
...
I ActivityManager: Killing 2145:com.android.systemui/u0a126 (adj -800): Too many Binders sent to SYSTEM
I am_kill : [User=0,PID=2145,Process Name=com.android.systemui,OomAdj=-800,Reason=Too many Binders sent to SYSTEM,Rss=477156B]
StrictMode#initVmDefaults calls builder.detectAll() for all bundled system apps on userdebug and eng
builds. detectAll() includes DETECT_VM_BACKGROUND_ACTIVITY_LAUNCH_ABORTED. SystemUI is a bundled
system app, so it gets this flag at startup. With this flag, every call to StrictMode#setVmPolicy
will trigger StrictMode#registerBackgroundActivityLaunchCallback.
A hot path is in LoadedApk which SystemUI calls very often when managing notification UI. In
LoadedApk#canAccessDataDir, the following pattern is used which should demonstrate how this leak
can happen:
StrictMode.VmPolicy old = StrictMode.allowVmViolations();
try {
// StrictMode violation code
} finally {
StrictMode.setVmPolicy(old); // re-registers a new BAL callback every time
}
It's not unexpected for other apps to be following this pattern as well.
The following is a stacktrace of how SystemUI adds new BAL callbacks. This runs on every
notification that gets posted:
```
W StrictMode: java.lang.Throwable
W StrictMode: at android.os.StrictMode.registerBackgroundActivityLaunchCallback(StrictMode.java:2230)
W StrictMode: at android.os.StrictMode.setVmPolicy(StrictMode.java:2222)
W StrictMode: at android.app.LoadedApk.setVmPolicy(LoadedApk.java:875)
W StrictMode: at android.app.LoadedApk.canAccessDataDir(LoadedApk.java:1170)
W StrictMode: at android.app.LoadedApk.createOrUpdateClassLoaderLocked(LoadedApk.java:962)
W StrictMode: at android.app.LoadedApk.getClassLoader(LoadedApk.java:1183)
W StrictMode: at android.app.ActivityThread.getTopLevelResources(ActivityThread.java:3169)
W StrictMode: at android.app.ApplicationPackageManager.getResourcesForApplication(ApplicationPackageManager.java:2199)
W StrictMode: at android.app.ApplicationPackageManager.getResourcesForApplication(ApplicationPackageManager.java:2182)
W StrictMode: at android.app.ApplicationPackageManager.getResourcesForApplication(ApplicationPackageManager.java:2218)
W StrictMode: at android.graphics.drawable.Icon.loadDrawableAsUser(Icon.java:616)
W StrictMode: at com.android.systemui.statusbar.StatusBarIconView.getIcon(StatusBarIconView.java)
W StrictMode: at com.android.systemui.statusbar.StatusBarIconView.updateDrawable(StatusBarIconView.java)
W StrictMode: at com.android.systemui.statusbar.StatusBarIconView.set(StatusBarIconView.java)
W StrictMode: at com.android.systemui.statusbar.notification.icon.IconManager.setIcon(IconManager.java)
W StrictMode: at com.android.systemui.statusbar.notification.icon.IconManager.createIcons(IconManager.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.inflation.NotificationRowBinderImpl.inflateViews(NotificationRowBinderImpl.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.NotifInflaterImpl.inflateViewsImpl(NotifInflaterImpl.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.coordinator.PreparationCoordinator.inflateEntry(PreparationCoordinator.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.coordinator.PreparationCoordinator.inflateRequiredNotifViews(PreparationCoordinator.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.coordinator.PreparationCoordinator.inflateRequiredGroupViews(PreparationCoordinator.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.coordinator.PreparationCoordinator$$ExternalSyntheticLambda2.onBeforeFinalizeFilter(PreparationCoordinator.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.ShadeListBuilder$$ExternalSyntheticLambda12.accept(ShadeListBuilder.java)
W StrictMode: at com.android.systemui.util.NamedListenerSet.forEachTraced(NamedListenerSet.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.ShadeListBuilder$$ExternalSyntheticLambda7.run(ShadeListBuilder.java)
W StrictMode: at com.android.systemui.statusbar.notification.collection.NotifPipelineChoreographerImpl$frameCallback$1.doFrame(NotifPipelineChoreographerImpl.kt)
W StrictMode: at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1628)
W StrictMode: at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1639)
W StrictMode: at android.view.Choreographer.doCallbacks(Choreographer.java:1235)
W StrictMode: at android.view.Choreographer.doFrame(Choreographer.java:1160)
W StrictMode: at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1613)
```
There's also another path from
com.android.systemui.statusbar.notification.collection.coordinator.MediaCoordinator.shouldFilterOut
not shown here.
The SystemUI crash only occurs on userdebug/eng, but any app using the BAL StrictMode methods or the
StrictMode#enableDefaults will have this leak as well.
Note that StrictMode's BackgroundActivityLaunchCallback only calls static methods, so there's really
no point in making new instances for every call. system_server doesn't do anything with newly added
callbacks other than add it to an ArrayMap and link a death recipient. This also follows the
approach of StrictMode's existing usage of sUnsafeIntentCallback.
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
fix for mtk and low-end devices perf regression caused by fixed dp translate and fade animation Change-Id: Ibaf8a426b6e1d819dde9f131c8ef50b0268d24e9 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I0bc91f3c97af7995fc3174f72dedd6febb291ec6 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
preloading the animations during application bind, makes the activity loading way more faster, removing the latency during activity launch click Change-Id: I8ae7e6c950d710593e695e94ae152d6815637d67 Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com>
Change-Id: Ieec1869bac37104cd8733278865cf44e773b8971 Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I8c436985a1c7c2a96453f5163022ff279e82af90 Signed-off-by: Saikrishna1504 <saikrishna26918@gmail.com>
…margin On devices with a low-positioned UDFPS icon, the lockscreen chip can overlap and render behind it in collapsed mode. Align the chip with the keyguard indication margin and use the `keyguard_indication_margin_bottom` overlay to adjust placement per device as needed. Change-Id: I4f253bc37ba3f565f4c480ce30a4f3beabfc7d9e
fix notification animation oscillation during expansion - use aosp transition api fix resource usage when showing media chip - remove waveform animation and use 1 iteration marquee low udfps position algorithm chip content changes transform animaton Change-Id: I9087d504bf126c7d8b5d35486f9d39e6b0564026
AxionAOSP/issue_tracker#110 Change-Id: Ib95eb4807a374d362734c940c3f82a118b3a301b Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I3777f3899ede8b2bc94e64aeaeac7fa4dd262ab1 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I29bca3b6435ac95bf4dc76ac95bf4dc76ac95bf5 Signed-off-by: Saikrishna1504 <saikrishna26918@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com> Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Ghosuto <clash.raja10@gmail.com>
The mProfilerSnapshotTimer, defined internally by SystemServer in 2014, is no longer in use and should be removed. Signed-off-by: Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com> Change-Id: I2ae871561b4a5440d465a9568af7f761026dc0c6
If the current notification list contains only one group notification, and that group notification includes both OnGoing notifications and normal notifications, the Clear All button will display normally. However, when Clear All is executed, there is no animation; normal notifications are simply deleted, and the panel does not collapse. This is because viewsToAnimateAway is empty at this point, but rowsToDismissInBackground is not empty.There is no animation bug:531917470 Change-Id: I44ee42ef3e77f01328e365b4c55e7aca93267089
Flag: com.android.systemui.flashlight_strength Bug: 446110051 Test: manual. open flashlight dilaog, verify separator has enough contrast from the background. Change-Id: Iaaaecfdd0941e75e519358546c9b1e74e00ac848 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
When removing a media card, pagerState.currentPage could be updated out of sync with the viewModel cards, causing a crash. This change adds viewModel.cards.size as a key so that we get both relevant updates, and only call onCardSelected when valid. Fixes: 452266758 Test: QSMediaControllerUmoInQqsAndQs Test: manual - add/remove multiple media players Flag: com.android.systemui.scene_container Flag: com.android.systemui.media_controls_in_compose Change-Id: I555b8a80651e79296cb4809c52306d741e6bd06d Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Flag: com.android.systemui.scene_container Flag: com.android.systemui.media_controls_in_compose Fix: 468267280 Test: Checked UI - taps on playPause button on UMO. Change-Id: I013a7e51e0b4f0f741e8c6d80c39345cdf227df7 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I99b63bb159bf501049d9b16b755141c8d06a53f7 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I253aeb9c6f1344cfd1e637aa96b3e8f9d68ecb30 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I6c927575d1ccd0a5af1f1d43fa6ca6e949380583 Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I1c2201b2eac267c1af7b65ad31327c517c8803c8 Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I684dc77bd89fcab8fb51b342a3dc76c3b6afe687 Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I14a14ab89afbecaca4b2af59403ed3b5b1eda37c Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
the backdrop was heavy and messy, mtk hates complex fade animations, programatically load app start animation to reduce pressure during splash screen animation, simpleperf shows parsing the animation from xml consumes high cpu usage due to resource lookup. Change-Id: Icc38c2d3db1a05ceedf41433d13cc75a8de7732f Signed-off-by: rmp22 <195054967+rmp22@users.noreply.github.com> Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Ghosuto <clash.raja10@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Parse optional id attributes on java-symbol entries and preserve private resource IDs while merging resource tables. Pin the contextual search framework resources to the IDs expected by the Pixel Launcher prebuilt. Without this, resource ID 0x01040241 resolves to config_defaultContextualSearchLegacyEnabled instead of config_defaultContextualSearchPackageName, causing contextual search availability checks to fail.
Fixes: crdroidandroid/issue_tracker#1079 Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
* followup for 7d00865ae9250da503410ddb1763183526833ba2 reference: https://android-review.googlesource.com/c/platform/frameworks/base/+/2492460 Signed-off-by: minaripenguin <minaripenguin@users.noreply.github.com> Signed-off-by: Dmitrii <bankersenator@gmail.com> Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
The Camera2 rewrite adds the preview as a fullscreen TYPE_APPLICATION_OVERLAY window without FLAG_NOT_TOUCHABLE. A fullscreen touchable window consumes every pointer event within its bounds, so nothing reaches the UI beneath it and the screen is effectively frozen while OnTheGo is active. Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Fix the issue that the ProgramList return from filterAndApplyChunkInternal has duplicated radio stations，caused by processing modified first and then removed in ProgramInfoCache.java Change-Id: Ia5fdc3b8ae5d4ace6b55836585efe96d2c4d56a8
…ing app preference Reset Root Cause: The new early-continue for uidState.getState() >= AppOpsManager.UID_STATE_CACHED changes resetAllModes() semantics: getUidState() defaults to MIN_PRIORITY_UID_STATE (CACHED) for UIDs not currently tracked/running, and UID_STATE_NONEXISTENT is also >= CACHED. This means reset will now skip most (or all) non-running apps, so app-op modes won’t be reset for those packages/UIDs, which breaks the contract of “reset all modes” and can also break the targeted reqPackageName case if that UID happens to be cached. If the goal is to avoid the expensive work for UIDs that don’t correspond to real packages / only contain overlays, consider gating on the package list (e.g., skip only when getPackagesForUid(uid) is empty and the UID isn’t reqUid, and/or explicitly filtering overlay/RRO packages) and keep package-level pkgOps reset behavior intact rather than skipping the entire UIDState. Resolution: We had put if condition and we are skipping those UidStates list has cch state and containing overlay/RRO packages. Bug: 501475025 Change-Id: Ib31850429b4e3fb20c8a911f004e40fb6b52449a Signed-off-by: Shailendra Gupta <sgupta96@ford.com>
Root Cause: resetAllModes() collected UID mode changes in an ArraySet and registered operation watchers once for every package associated with the UID. For shared UIDs, or when getPackagesForUid() returned duplicate package names, this could collect duplicate callback records and notify the same watcher multiple times. The callback collection also did not verify that a listener was registered for the UID being reset. Consequently, UID-scoped listeners could receive mode-change notifications for unrelated UIDs. Using an ArraySet for allChanges additionally caused reset records to be implicitly collapsed according to ChangeRec equality. This could prevent individual mode changes from being forwarded correctly to StorageManager. Resolution: Filter listeners in addCallbacks() using isWatchingUid() so callbacks are collected only when the listener watches the affected UID. Preserve UID_ANY behavior for callbacks that are not scoped to a particular UID. Deduplicate the package names returned for a UID before collecting package-specific callbacks and StorageManager notifications. Avoid registering operation watchers repeatedly while iterating over packages for a UID mode reset. Replace the allChanges ArraySet with an ArrayList so every explicitly collected reset is retained and forwarded to StorageManager in collection order. Create ChangeRec entries directly and remove the unused addChange() helper. These changes prevent duplicate and unrelated app-op callbacks while ensuring that all valid reset operations are propagated to StorageManager. Bug: 501475025 Change-Id: Ib31850429b4e3fb20c8a911f004e40fb6b52449a Signed-off-by: Shailendra Gupta <sgupta96@ford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
After applying separate static HOME and LOCK wallpapers, ImageWallpaper could leave HOME primaryColors null. ThemePicker then had no HOME palette. Separately, clock backgrounds were recreated only when their style or position changed, so they retained drawables from the previous fabricated overlay.
Runtime validation