Feat/pgo v3

[henderkes]

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

• If you modified *.php or *.json, run them locally to ensure your changes are valid:
  • composer cs-fix
  • composer analyse
  • composer test
  • bin/spc dev:sort-config
• If it's an extension or dependency update, please ensure the following:
  • Add your test combination to src/globals/test-extensions.php.
  • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

[github-actions]

StaticPHP Test Bot

Detected: Extensions: fastchart, fastjson | Libraries: bzip2, fastlz, icu, imagemagick, jbig, krb5, libaom, libffi, libheif, liblz4, libpng, ncurses, openssl, postgresql, qdbm, unixodbc, watcher | Targets: llvm-compiler-rt, llvm-tools, php
Active labels: none
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

[henderkes]

(I tested with static-php/packages v3 branch, php 8.5 zig on rpm. Tests with Alpine and gcc are still to finish in a few hours when ci runs.)

[henderkes]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

[crazywhalecc]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

[henderkes]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

Okay, added curl.exe on Windows too. Also figured out the root cause of the BUILD_CC patch minilua crash (zigs undefined behaviour sanitizer tripping up, if you run CC="clang -fsanitize=undefined" it will also fail) which coincidentally also fixed a possible edge case bug. BUILD_CC is also used for gen_ir so by using a different vm type it could have theoretically clashed.

[henderkes]

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

[henderkes]

wtf I have no idea what failed in the tests and why. it passes locally and looking for php-config there makes no sense, neither of the new extensions does it

[luthermonson]

had claude pull everything and this is what it thinks the problem is with CI

Why it broke now (not a PR regression)

  The earlier runs on this same PR (02:27, 06:11 today) passed. Then it broke at 08:43.

  - 06:11 green run used mongodb-2.3.2.tgz
  - 08:43 failed run used mongodb-2.3.3.tgz
  - mongodb 2.3.3 was released today at 07:07:49Z — right between those two runs
  - spc's ext-mongodb.yml uses type: ghrel + match: mongodb.+\.tgz, which always pulls the latest mongodb release. So CI silently picked up the new
  version.

I'll get a PR up with the fix and we'll see if it's right

[henderkes]

(current CI failures are because I didn't forward the temporary fixes for fastchart and clickhouse extensions, iliaa will probably release versions with my fixes upstreamed in a few days)

[crazywhalecc]

I'd like to merge some easily split parts of this branch into v3 first, so that the branch doesn't become too large and make reviews troublesome.

[henderkes]

Yes, I'm getting to a point where building static-php/packages based on this branch is possible. The majority of changes here are really just behaviour fixes that can be applied independently.