Skip to content

add framework coreservices to watcher library#1082

Merged
crazywhalecc merged 1 commit intomainfrom
fix/watcher-macos
Apr 4, 2026
Merged

add framework coreservices to watcher library#1082
crazywhalecc merged 1 commit intomainfrom
fix/watcher-macos

Conversation

@henderkes
Copy link
Copy Markdown
Collaborator

What does this PR do?

closes php/frankenphp#2329 (comment)

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes requested a review from crazywhalecc April 4, 2026 11:19
@henderkes henderkes added the bug Something isn't working label Apr 4, 2026
@crazywhalecc crazywhalecc merged commit d411fac into main Apr 4, 2026
7 checks passed
@crazywhalecc crazywhalecc deleted the fix/watcher-macos branch April 4, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating static binaries on macOS fail with watcher enabled

2 participants