Skip to content

Conversation

@MungoG
Copy link
Contributor

@MungoG MungoG commented Jan 21, 2026

Summary by CodeRabbit

  • Refactor
    • Reorganized internal data structure management and memory handling across multiple I/O operation modules for improved code architecture and maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This PR systematically migrates intrusive list references across the codebase from capy::intrusive_list to capy::detail::intrusive_list, updating include paths and base class/member types accordingly. Additionally, scheduler_op.hpp introduces new public API methods (destroy(), data()) and protected members.

Changes

Cohort / File(s) Summary
EPOLL Platform Integration
src/corosio/src/detail/epoll/resolver_service.hpp, src/corosio/src/detail/epoll/sockets.hpp
Updated inheritance and member types from capy::intrusive_list to capy::detail::intrusive_list for resolver and socket implementations
IOCP Platform Integration
src/corosio/src/detail/iocp/resolver_service.hpp, src/corosio/src/detail/iocp/sockets.hpp
Migrated intrusive list base classes and members to detail namespace; updated include paths for socket wrapper classes
Signal Implementations
src/corosio/src/detail/posix/signals.hpp, src/corosio/src/detail/win/signals.hpp
Replaced signal impl inheritance from capy::intrusive_list<*>::node to capy::detail::intrusive_list<*>::node
Core Infrastructure
src/corosio/src/detail/scheduler_op.hpp
Migrated intrusive queue to detail namespace; added public destroy() virtual method and data() const accessor; introduced protected destructor and data member
Timer Service & Test Utilities
src/corosio/src/detail/timer_service.cpp, src/corosio/src/test/mocket.cpp
Updated timer impl and test mock impl to use detail namespace intrusive list variants

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • vinniefalco

Poem

🐰 With whiskers twitching at each line,
I hop through namespaces so fine,
From capy's lists to detail's door,
The intrusive nodes dance evermore!
A migrate-hop, so clean and bright,

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly relates to the main objective of the changeset: migrating intrusive_list references from capy::intrusive_list to capy::detail::intrusive_list across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://45.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-01-21 12:04:46 UTC

@MungoG MungoG closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants