-
Notifications
You must be signed in to change notification settings - Fork 6
TLS shutdown tests and fixes #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 134
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 158
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 1370
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 195
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 81
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 306
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 1834
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 1305
🏁 Script executed:
# Look at includes in the test file to understand how this should work head -50 ./test/unit/tls/wolfssl_stream.cppRepository: cppalliance/corosio
Length of output: 1769
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 195
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 2503
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 957
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
# Look at the complete includes and early definitions in wolfssl_stream.cpp head -100 ./src/wolfssl/src/wolfssl_stream.cppRepository: cppalliance/corosio
Length of output: 3802
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 522
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 47
🏁 Script executed:
# Try a web search to verify SSL_RECEIVED_SHUTDOWN in WolfSSLRepository: cppalliance/corosio
Length of output: 45
🌐 Web query:
SSL_RECEIVED_SHUTDOWN WolfSSL OpenSSL constant definition💡 Result:
Short answer:
OpenSSL: SSL_SENT_SHUTDOWN = 0x01 (value 1), SSL_RECEIVED_SHUTDOWN = 0x02 (value 2); they are shutdown-state bitflags (sent = close_notify sent, received = close_notify received). [1]
wolfSSL: wolfSSL_get_shutdown() returns 1 for SSL_SENT_SHUTDOWN and 2 for SSL_RECEIVED_SHUTDOWN (same numeric meanings). [2]
Sources:
[1] OpenSSL manpage SSL_set_shutdown / SSL_shutdown.
[2] wolfSSL documentation (wolfSSL_shutdown / wolfSSL_get_shutdown).
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 306
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 149
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 1484
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 45
🏁 Script executed:
Repository: cppalliance/corosio
Length of output: 302
SSL_RECEIVED_SHUTDOWN may not be available in all WolfSSL builds.
The code uses
SSL_RECEIVED_SHUTDOWNwithout verifying it's defined. While WolfSSL does support this constant when built with OpenSSL compatibility (--enable-opensslextraor--enable-opensslall), many standard distributions omit these flags. This will cause compilation errors on incompatible WolfSSL installations.Either:
FindWolfSSL.cmaketo verify OpenSSL compatibility mode is enabled, or#if !defined(SSL_RECEIVED_SHUTDOWN)#defineSSL_RECEIVED_SHUTDOWN 0x02#endif``)🤖 Prompt for AI Agents