Repository navigation
Benchmark fork PRs: name the head repository at checkout - #387
Merged
Merged
Conversation
actions/checkout refuses to fetch fork commits from a pull_request_target workflow unless the fork is named explicitly, so the first labeled fork PR failed at checkout. Naming it is safe here: the gate pins the head SHA at label time, the label is a maintainer's approval to run that code on the dedicated machines, and the checkout keeps no credentials.
Benchmark report
Run & raw JSON artifacts · flag rule: |median Δ| > max(2%, 3×CV of the noisier side) · advisory only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first labeled fork PR (#386) failed in all three bench jobs with:
actions/checkoutrequires the fork to be named explicitly before it will fetch fork commits underpull_request_target. The gate now exportshead_repo(the PR head's repository; the base repo on dispatch) and the bench jobs pass it to checkout.This stays within the workflow's security model: the head SHA is pinned by the gate at label time (a later push can't ride the approval), tooling always comes from the trusted base commit, the checkout keeps no credentials, and the benchmark label is precisely a maintainer's approval to run that code on the dedicated machines.