Skip to content

Conversation

@mvandeberg
Copy link
Contributor

@mvandeberg mvandeberg commented Jan 23, 2026

Summary by CodeRabbit

  • Refactor
    • Updated internal code structure with no impact to end-user functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Changes to src/ex/thread_pool.cpp update the include path from boost/capy/detail/thread_name.hpp to boost/capy/test/thread_name.hpp and remove the detail:: namespace qualifier from a set_current_thread_name() function call.

Changes

Cohort / File(s) Summary
Include and namespace refactor
src/ex/thread_pool.cpp
Changed thread_name header include path from detail/ to test/ directory and removed detail:: namespace prefix from set_current_thread_name() call

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

  • Feature: set_thread_name #107: Modifies the same file (src/ex/thread_pool.cpp) with similar changes to thread_name header includes and namespace qualifiers for set_current_thread_name().

Poem

🐰 A path through the detail, now moved to test,
The namespace dissolved, the code now compressed,
Two lines in, two lines out, so clean and so neat,
Thread names find their way—a refactor complete! ✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes moving thread_name to a test directory, but the PR objective is to make set_current_thread_name public, which are related but distinct goals.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link

cppalliance-bot commented Jan 23, 2026

An automated preview of the documentation is available at https://109.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-01-23 23:58:09 UTC

@cppalliance-bot
Copy link

cppalliance-bot commented Jan 23, 2026

GCOVR code coverage report https://109.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://109.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report (in development) https://109.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-01-24 00:07:19 UTC

@mvandeberg mvandeberg force-pushed the feature/public-thread-name branch from 04bd1cc to 744ab78 Compare January 23, 2026 23:53
@mvandeberg mvandeberg changed the title Make set_current_thread_name public Move thread_name to boost/capy/test Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants