Skip to content

Commit c33e41d

Browse files
shenxianpeng2bndy5
andauthored
update thread-comments default value to false #46 (#47)
* change thread-comments default value to false #46 * remove use of TOKEN when fetching thread comments This should resolve #46. It will not affect the fix for private repos since thread comments are now auto-disabled for private repos. Co-authored-by: Brendan <2bndy5@gmail.com>
1 parent f4c83ba commit c33e41d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ jobs:
115115
- **Description**: Set this option to false to disable the use of thread comments as feedback.
116116
- To use thread comments, the `GITHUB_TOKEN` (provided by Github to each repository) must be declared as an environment
117117
variable. See [Authenticating with the GITHUB_TOKEN](https://docs.github.com/en/actions/reference/authentication-in-a-workflow)
118-
- Default: true
118+
- Default: false
119119
- NOTE: If run on a private repository, then this feature is disabled because the GitHub REST API behaves differently for thread comments on a private repository.
120120

121121
#### `database`

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ inputs:
88
thread-comments:
99
description: Set this option to false to disable the use of thread comments as feedback. Defaults to true.
1010
required: false
11-
default: true
11+
default: false
1212
style:
1313
description: >
1414
The style rules to use (defaults to 'llvm').
@@ -37,7 +37,7 @@ inputs:
3737
required: false
3838
default: "10"
3939
verbosity:
40-
descruption: A hidden option to control the action's log verbosity. This is the `logging` level (degaults to DEBUG)
40+
description: A hidden option to control the action's log verbosity. This is the `logging` level (degaults to DEBUG)
4141
required: false
4242
default: "10"
4343
lines-changed-only:

cpp_linter/thread_comments.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def remove_bot_comments(comments_url: str, user_id: int):
1515
user_id: The user's account id number.
1616
"""
1717
logger.info("comments_url: %s", comments_url)
18-
Globals.response_buffer = requests.get(comments_url, headers=API_HEADERS)
18+
Globals.response_buffer = requests.get(comments_url)
1919
if not log_response_msg():
2020
return # error getting comments for the thread; stop here
2121
comments = Globals.response_buffer.json()

0 commit comments

Comments
 (0)