[container.requirements] Add consistent punctuation.#9202
Open
tkoeppe wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@notdanhan I realize we're currently being inconsistent, but I think everything should be punctuated. All these elements essentially sound like statements, even if some of them are very brief. |
notdanhan
approved these changes
Jul 17, 2026
jensmaurer
reviewed
Jul 17, 2026
jensmaurer
left a comment
jensmaurer
left a comment
Member
There was a problem hiding this comment.
I'm okay with these changes (although a lone keyword with a period following feels odd), but @jwakely should have a say here.
Contributor
Author
|
@jensmaurer We already have many lone keywords followed by a period. There was absolutely no consistency or majority before! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.