[numeric.limits.members] Correct footnotes and convert to notes and examples#9199
Open
eisenwave wants to merge 1 commit into
Open
[numeric.limits.members] Correct footnotes and convert to notes and examples#9199eisenwave wants to merge 1 commit into
eisenwave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many major issues with [numeric.limits.members] right now:
FLT_RADIX". This doesn't account fordoublebeing a decimal floating-point type (which is permitted I believe), and doesn't account for any extended floating-point types that are not binary.FLT,DBL, andLDBLmacro. However, with extended floating-point types, the value of the member can obviously be soemthing other than those three, so there needs to be aetc.somewhere.radixfor integers, accounting for representations like BCD. Seeing that since C++20, the representation of integers is always two's complement, this footnote no longer makes any sense.This PR cleans up all those problems.