Skip to content

[mdspan.layout.leftpad.obs, mdspan.layout.rightpad.obs] Fix return type of operator()#8945

Open
hewillk wants to merge 1 commit intocplusplus:mainfrom
hewillk:main-operator
Open

[mdspan.layout.leftpad.obs, mdspan.layout.rightpad.obs] Fix return type of operator()#8945
hewillk wants to merge 1 commit intocplusplus:mainfrom
hewillk:main-operator

Conversation

@hewillk
Copy link
Copy Markdown
Contributor

@hewillk hewillk commented Apr 16, 2026

This is consistent with the declaration.

@jwakely
Copy link
Copy Markdown
Member

jwakely commented Apr 16, 2026

I agree that this is editorial.

@jensmaurer
Copy link
Copy Markdown
Member

jensmaurer commented Apr 16, 2026

This fixes an incomplete application of P2599R2 index_type & size_type in mdspan
applied in commit 7fbd063

@hewillk , could you please update the commit description accordingly and force-push? Thanks.

@jensmaurer jensmaurer added this to the post-2026-03 milestone Apr 16, 2026
@jensmaurer jensmaurer added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Apr 16, 2026
@hewillk
Copy link
Copy Markdown
Contributor Author

hewillk commented Apr 16, 2026

This fixes an incomplete application of P2599R2 index_type & size_type in mdspan applied in commit 7fbd063

@hewillk , could you please update the commit description accordingly and force-push? Thanks.

Sorry, why is this related to P2599R2?
It seems to me that this is most likely a typo, because the function has been declared as constexpr index_type operator()(Indices...) const noexcept in [mdspan.layout.leftpad.overview].

@jensmaurer
Copy link
Copy Markdown
Member

Ah, right, this is a bug in P2642R6, where the inconsistent declarations were added originally.

@jensmaurer
Copy link
Copy Markdown
Member

... but please remove "'m not sure if this is LWG; I doubt it." from the commit description and force-push; this is good discussion for the pull request, but has little value in the commit history.

@hewillk
Copy link
Copy Markdown
Contributor Author

hewillk commented Apr 17, 2026

... but please remove "'m not sure if this is LWG; I doubt it." from the commit description and force-push; this is good discussion for the pull request, but has little value in the commit history.

Done. Is this okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants