[Motions 2026 03 lwg 1] P4145R0 C++ Standard Library Ready Issues#8926
Merged
[Motions 2026 03 lwg 1] P4145R0 C++ Standard Library Ready Issues#8926
Conversation
Member
|
I have added "fixes cplusplus/nbballot" links in the initial comment of this pull request. It would be good to amend the corresponding commits with our usual "Fixes NB ... (C++26 CD)." text (examples all over "git log"). |
c3db190 to
1ec13a4
Compare
1ec13a4 to
076fc37
Compare
Member
|
The fourth commit in the series (fd289eb) says "CWG" instead of "LWG" in the commit log. |
jwakely
reviewed
Apr 9, 2026
jwakely
reviewed
Apr 9, 2026
jwakely
reviewed
Apr 9, 2026
jwakely
reviewed
Apr 9, 2026
jwakely
approved these changes
Apr 9, 2026
Member
jwakely
left a comment
There was a problem hiding this comment.
I added a few minor comments but everything looks correct. Nice work, Dawn!
7014982 to
824dc70
Compare
…ained by const Pattern
Editorial note: * [atomics.ref.ops]p3 Added "," to match wording added in p1.
Fixes NB GB 05-129 (C++26 CD).
…only concept duplication Fixes NB US 151-242 (C++26 CD).
…r parallel algorithms
…the difference type is also a sentinel type
…td::basic_string on some platforms Editorial note: * [string.find] Use braces in complex if statement.
…[] specification
Fixes NB US 157-255 (C++26 CD).
…nstant_array and related functions
Fixes NB US 152-243, PL 008 (C++26 CD).
824dc70 to
a3bbccb
Compare
tkoeppe
reviewed
Apr 12, 2026
| then \tcode{options.name} does not contain a value; and | ||
| \item | ||
| if \tcode{options.name} does not contain a value, then | ||
| \tcode{is_const(type) || is_volatile(type)} is \tcode{false}; and |
Contributor
There was a problem hiding this comment.
We're picking up a lot of "; and"s here, but that's what the paper says.
Contributor
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8835.
Also fixes cplusplus/nbballot#708
Also fixes cplusplus/nbballot#814
Also fixes cplusplus/nbballot#879
Also fixes cplusplus/nbballot#855
Also fixes cplusplus/nbballot#830
Also fixes cplusplus/nbballot#817
Also fixes cplusplus/nbballot#815
Notes: