-
Notifications
You must be signed in to change notification settings - Fork 29
docs: disable KVM nested virtualization in Talos install configs (CVE-2026-53359) #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -85,6 +85,13 @@ Discovered open port 50000/tcp on 192.168.123.13 | |||||||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||||||
|
Comment on lines
+88
to
+94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the The list items are rendered at the same indentation level as Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -65,6 +65,13 @@ talos-bootstrap --help | |||||||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||||||
|
Comment on lines
+68
to
+74
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the This block reads as if the sequence items are at the same level as Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -85,6 +85,13 @@ Discovered open port 50000/tcp on 192.168.123.13 | |||||||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||||||
|
Comment on lines
+88
to
+94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the As written, the list items sit alongside Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -65,6 +65,13 @@ talos-bootstrap --help | |||||||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||||||
|
Comment on lines
+68
to
+74
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the The current indentation makes the list items look sibling-level to Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -85,6 +85,13 @@ Discovered open port 50000/tcp on 192.168.123.13 | |||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||
|
Comment on lines
+88
to
+94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the The example needs the sequence items nested under Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -65,6 +65,13 @@ talos-bootstrap --help | |||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||
|
Comment on lines
+68
to
+74
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the As rendered here, the sequence items are not nested under Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -85,6 +85,13 @@ Discovered open port 50000/tcp on 192.168.123.13 | |||||||||||||||||||||||||||||
| - name: vfio_iommu_type1 | ||||||||||||||||||||||||||||||
| install: | ||||||||||||||||||||||||||||||
| image: ghcr.io/cozystack/cozystack/talos:{{< version-pin "talos" >}} | ||||||||||||||||||||||||||||||
| # On Talos >=1.12 pin grubUseUKICmdline false so the args land on the | ||||||||||||||||||||||||||||||
| # Talos-built cmdline (Talos rejects/ignores extraKernelArgs under UKI). | ||||||||||||||||||||||||||||||
| grubUseUKICmdline: false | ||||||||||||||||||||||||||||||
| extraKernelArgs: | ||||||||||||||||||||||||||||||
| # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation) | ||||||||||||||||||||||||||||||
| - kvm_intel.nested=0 | ||||||||||||||||||||||||||||||
| - kvm_amd.nested=0 | ||||||||||||||||||||||||||||||
|
Comment on lines
+88
to
+94
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Indent the The sequence items need to be nested under Fix grubUseUKICmdline: false
extraKernelArgs:
- # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
- - kvm_intel.nested=0
- - kvm_amd.nested=0
+ # CVE-2026-53359: disable KVM nested virtualization (guest-to-host escape mitigation)
+ - kvm_intel.nested=0
+ - kvm_amd.nested=0📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||
| registries: | ||||||||||||||||||||||||||||||
| mirrors: | ||||||||||||||||||||||||||||||
| docker.io: | ||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with Talos 1.10, fresh installations on UEFI systems use systemd-boot and Unified Kernel Images (UKIs). On these systems, the
.machine.install.extraKernelArgsfield in the machine configuration is completely ignored because kernel arguments are embedded directly within the UKI.Since all documentation versions from
v0(using Talos v1.10.3) tonext(using Talos v1.13.0) target Talos 1.10+, this mitigation will be silently ignored on any UEFI-booted nodes, leaving them vulnerable to CVE-2026-53359.To ensure users are actually protected, please add a warning note in the documentation explaining that on UEFI-booted systems, these kernel arguments must be baked into the boot assets using the Image Factory or Imager (via customization schematics) instead of relying on
extraKernelArgsin the machine configuration.