fix(backup): simplify UX with default backupclass#547
Conversation
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
androndo
force-pushed
the
feat/backup-default-class
branch
2 times, most recently
from
7e9b1ae to
3cd5d7b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consolidates backup documentation by replacing the 'Managed Application Backup Configuration' and 'Velero Backup Configuration' guides with a new, unified 'Backup Classes' guide across both the 'next' and 'v1.4' documentation versions. Feedback from the review highlights that the new guide is missing critical troubleshooting information ('Tenant escalation: driver-side diagnostics') and detailed strategy examples for ClickHouse and Velero that were present in the deleted files. Additionally, the reviewer pointed out redundant links in the 'See also' sections and minor typos in the new documentation.
| - [Backup Classes]({{% ref "/docs/next/operations/services/backup-classes" %}}) — how administrators define strategies and `BackupClass` resources. | ||
| - [Backup and Recovery (VMs)]({{% ref "/docs/next/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). | ||
| - [Velero Backup Configuration]({{% ref "/docs/next/operations/services/velero-backup-configuration" %}}) — administrator setup for the Velero-driven VM backups. | ||
| - [Backup Classes]({{% ref "/docs/next/operations/services/backup-classes" %}}) — administrator setup for the Velero-driven VM backups. |
There was a problem hiding this comment.
The 'See also' section now contains two identical links to the 'Backup Classes' guide. Since the new guide covers both managed applications and general backup class configuration, these links should be merged to avoid redundancy.
| - [Backup Classes]({{% ref "/docs/next/operations/services/backup-classes" %}}) — how administrators define strategies and `BackupClass` resources. | |
| - [Backup and Recovery (VMs)]({{% ref "/docs/next/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). | |
| - [Velero Backup Configuration]({{% ref "/docs/next/operations/services/velero-backup-configuration" %}}) — administrator setup for the Velero-driven VM backups. | |
| - [Backup Classes]({{% ref "/docs/next/operations/services/backup-classes" %}}) — administrator setup for the Velero-driven VM backups. | |
| - [Backup Classes]({{% ref "/docs/next/operations/services/backup-classes" %}}) — how administrators define strategies and BackupClass resources. | |
| - [Backup and Recovery (VMs)]({{% ref "/docs/next/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). |
| - [Backup Classes]({{% ref "/docs/v1.4/operations/services/backup-classes" %}}) — how administrators define strategies and `BackupClass` resources. | ||
| - [Backup and Recovery (VMs)]({{% ref "/docs/v1.4/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). | ||
| - [Velero Backup Configuration]({{% ref "/docs/v1.4/operations/services/velero-backup-configuration" %}}) — administrator setup for the Velero-driven VM backups. | ||
| - [Backup Classes]({{% ref "/docs/v1.4/operations/services/backup-classes" %}}) — administrator setup for the Velero-driven VM backups. |
There was a problem hiding this comment.
The 'See also' section now contains two identical links to the 'Backup Classes' guide. Since the new guide covers both managed applications and general backup class configuration, these links should be merged to avoid redundancy.
| - [Backup Classes]({{% ref "/docs/v1.4/operations/services/backup-classes" %}}) — how administrators define strategies and `BackupClass` resources. | |
| - [Backup and Recovery (VMs)]({{% ref "/docs/v1.4/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). | |
| - [Velero Backup Configuration]({{% ref "/docs/v1.4/operations/services/velero-backup-configuration" %}}) — administrator setup for the Velero-driven VM backups. | |
| - [Backup Classes]({{% ref "/docs/v1.4/operations/services/backup-classes" %}}) — administrator setup for the Velero-driven VM backups. | |
| - [Backup Classes]({{% ref "/docs/v1.4/operations/services/backup-classes" %}}) — how administrators define strategies and BackupClass resources. | |
| - [Backup and Recovery (VMs)]({{% ref "/docs/v1.4/virtualization/backup-and-recovery" %}}) — the parallel guide for VMInstance / VMDisk backups (HelmRelease + CRs + PVC snapshots). |
| name: orders-db | ||
| ``` | ||
|
|
||
| See [Applications backup and recovery]({{% ref "/docs/next/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. |
There was a problem hiding this comment.
There is a minor typo in the link text ('Applications' instead of 'Application') and the guide is missing the 'Tenant escalation: driver-side diagnostics' section from the removed documentation. This section is essential for administrators to troubleshoot failed tenant backups and is still referenced by the tenant guides (e.g., in backup-and-recovery.md). Additionally, consider migrating the detailed strategy configuration examples for ClickHouse and Velero that were lost during the removal of the old guides, as administrators still need this information for non-default setups.
| See [Applications backup and recovery]({{% ref "/docs/next/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. | |
| See [Application backup and recovery]({{% ref "/docs/next/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. |
| name: orders-db | ||
| ``` | ||
|
|
||
| See [Applications backup and recovery]({{% ref "/docs/v1.4/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. |
There was a problem hiding this comment.
There is a minor typo in the link text ('Applications' instead of 'Application') and the guide is missing the 'Tenant escalation: driver-side diagnostics' section from the removed documentation. This section is essential for administrators to troubleshoot failed tenant backups and is still referenced by the tenant guides (e.g., in backup-and-recovery.md). Additionally, consider migrating the detailed strategy configuration examples for ClickHouse and Velero that were lost during the removal of the old guides, as administrators still need this information for non-default setups.
| See [Applications backup and recovery]({{% ref "/docs/v1.4/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. | |
| See [Application backup and recovery]({{% ref "/docs/v1.4/applications/backup-and-recovery" %}}) for the full Plan / BackupJob / RestoreJob walkthrough. |
…and backupclass Signed-off-by: Andrey Kolkov <androndo@gmail.com>
androndo
force-pushed
the
feat/backup-default-class
branch
from
3cd5d7b to
383e398
Compare
1 participant
No description provided.