Skip to content

fix(template): require --file or --template flag #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvaps merged 1 commit into from
Mar 19, 2026
+4 −3
Merged

fix(template): require --file or --template flag #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/commands/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ var templateCmd = &cobra.Command{
templateFunc := template
if len(templateCmdFlags.configFiles) > 0 {
templateFunc = templateWithFiles
if len(templateCmdFlags.configFiles) == 0 {
return fmt.Errorf("cannot use --in-place without --file")
}
}

if templateCmdFlags.offline {
Expand Down
4 changes: 4 additions & 0 deletions pkg/engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ func Render(ctx context.Context, c *client.Client, opts Options) ([]byte, error)
return nil, err
}

if len(opts.TemplateFiles) == 0 {
return nil, fmt.Errorf("templates are not set for the command: please use `--file` or `--template` flag")
}
Comment on lines +244 to +246
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better efficiency, this check should be at the beginning of the Render function. Placing it here means that chart loading and template rendering (loader.LoadDir, loadValues, eng.Render) are performed even when they are not needed, only to fail afterwards. Moving this check to the top of the function would allow it to fail-fast and avoid these unnecessary operations.


configPatches := []string{}
for _, templateFile := range opts.TemplateFiles {
// Use path.Join (not filepath.Join) because helm engine keys always use forward slashes
Expand Down
Loading