Migrate e2e tests from ethcontract to alloy primitives

[jmg-duarte]

Description

Removes ethcontract dependency from e2e crate and converts remaining type usages (H160, U256, Bytes) to their alloy equivalents.

Changes

• H160 -> Address
• Bytes<[32; u8]> -> U256
• Refactor callsites accordingly

How to test

Existing tests

[gemini-code-assist]

Summary of Changes

Hello @jmg-duarte, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to modernize the codebase by migrating away from the ethcontract library. The primary goal is to standardize on alloy primitives for Ethereum-related types, enhancing consistency and reducing dependency overhead. This change impacts several core components, streamlining type handling and simplifying interactions with blockchain data.

Highlights

• Dependency Removal: The ethcontract dependency has been completely removed from the e2e crate, streamlining the project's dependencies.
• Type Migration: H160 to Address: All instances of ethcontract::H160 have been migrated to alloy::primitives::Address, standardizing address representation across the codebase.
• Type Migration: U256: Explicit conversions for U256 values using .into_alloy() and .into_legacy() have been removed, as alloy::primitives::U256 is now used directly.
• Type Migration: Bytes: The ethcontract::Bytes type has been replaced with alloy::primitives::Bytes and alloy::primitives::B256 where appropriate, simplifying byte array handling.
• Call Site Refactoring: Numerous call sites have been refactored to directly utilize the new alloy primitive types, eliminating the need for explicit conversion traits like IntoAlloy and IntoLegacy.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully migrates e2e tests and parts of the shared crate from ethcontract primitives to alloy primitives. The changes are clean, consistent, and correctly replace types like H160 and Bytes with their alloy equivalents (Address, B256, Bytes). The removal of the ethcontract dependency from the e2e crate is a good step towards modernizing the codebase. The use of the address! macro is a nice improvement for readability and compile-time correctness. The refactoring appears to be purely mechanical without any logic changes, which is great. Overall, this is a solid piece of work.