Set up PR checks and a pull request template#37
Merged
Merged
Conversation
GitHub Actions runs lint and build on every pull request, and the PR template reminds contributors to confirm checks and hardware validation. Co-authored-by: Cursor <cursoragent@cursor.com>
Include pnpm run test in CI and the pull request template so unit tests gate merges alongside lint and build. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestand executespnpm install --frozen-lockfile,pnpm run lint,pnpm run test, andpnpm run build..github/pull_request_template.mdwith fields for linked issue, summary, lint/test/build confirmation, and manual Reader/card hardware validation notes.Closes #33
Notes
The issue scoped
npm ci, but this repo's lockfile ispnpm-lock.yaml(nopackage-lock.json). The workflow usespnpm install --frozen-lockfilefor the same deterministic install behavior.package.jsonscripts are unchanged; contributors can still runnpm run lint/npm run test/npm run buildlocally if they prefer npm.Test plan
pnpm run lintpasses locallypnpm run testpasses locally (36 tests)pnpm run buildpasses locallyMade with Cursor