Skip to content

Columnar query: Clear callback when failing to create pending_op #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Columnar query: Clear callback when failing to create pending_op #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/columnar/query_component.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ class pending_query_operation
}
}

auto clear_callback()
{
const std::scoped_lock lock{ callback_mutex_ };
callback_ = nullptr;
}

auto dispatch() -> error
{
auto op = http_.do_http_request(
Expand Down Expand Up @@ -156,7 +162,9 @@ class pending_query_operation
#else
return_error.ec = op.error();
#endif
invoke_callback({}, return_error);

clear_callback();

return return_error;
}

Expand Down