Repository navigation
fix(ui): correct particle input semantics and constraints - #883
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
pasqualevitiello
marked this pull request as ready for review
October 14, 2026 19:53
pasqualevitiello
enabled auto-merge (squash)
October 14, 2026 19:53
sean-brydon
approved these changes
Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct input contracts in the particle examples: unnamed textareas and first OTP inputs, an authored OTP error that never appears, input focus lost on clearing, and an unenforced bio limit. The first OTP slots now inherit names from COSS
FieldLabel, and the OTP guide uses the same pattern. Regenerated registry assets include the updated@coss/fielddependencies.The composer keeps its static “Press Enter to send” hint by design; its physical
ml-autois replaced with logicalms-auto. Enter still inserts a newline and Send has no authored action. This PR does not claim to resolve F44.Affected: p-dialog-4, p-textarea-10, p-input-group-22/29, p-otp-field-1/2/3/7, p-field-10, and OTP guidance. Covers approved findings F03, F07, F32, F33, and F36.
Validation:
apps/uiTypeScript, Biome, registry dependency validation, registry generation, andgit diff --checkpassed. Chromium confirmed textarea names; first-slot names in all three OTP examples usingFieldLabel; invalid → valid → partial OTP messages; clear-focus behavior; and the bio limit. The composer hint and logical spacing render as intended. Physical screen-reader speech and OS clipboard paste were not tested. No local full build or E2E suite ran.No shared API or send workflow is introduced. Revert the PR commits to roll back.