Repository navigation
fix(particles): apply approved text treatments - #874
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
pasqualevitiello
marked this pull request as ready for review
October 14, 2026 19:36
pasqualevitiello
enabled auto-merge (squash)
October 14, 2026 19:38
sean-brydon
approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the approved local text treatments in the password requirement, action-count, and theme-card particles. Completed password requirements now use
text-success-foreground; both action counts use 64% opacity;p-popover-4uses a span instead of a Badge for its count; unselected theme-card labels use 72% opacity. The popover's unused Badge registry dependency is removed.Verified with
apps/uitypecheck, scoped Biome, registry dependency validation and generation, and local Chromium in both themes. Completed password text measures 5.36:1 in light and 9.50:1 in dark. Both 64% counts measure 6.82:1 light and 4.48:1 dark. Unselected theme labels measure 3.11:1 light and 3.07:1 dark. The latter two treatments follow the approved values but remain below 4.5:1; this PR does not claim those contrast issues are fully resolved. No further visual values were substituted.