fix(box): attempts on a repository GitHub doesn't host finish with the pick, and a pull request that doesn't open can be retried

[sean-brydon]

Fixes #138.

Before

The pr step pushed and then ran gh pr create on any remote. On Gitea, gh failed ("none of the git remotes … point to a known GitHub host"), and the step failed with it. The attempts template's cleanup runs only after success, so the whole run failed, cleanup was skipped and every worktree stayed behind. A finished run has no way to retry a step.

What changed

Checking the host first (internal/box/prhost.go):

• The step reads origin's host. An SSH alias is resolved with ssh -G --, which reads the config and connects to nothing.
• gh is used only for github.com, or for a host where gh auth status --hostname H succeeds (GitHub Enterprise).
• On any other host (Gitea, Forgejo, GitLab, or a folder), the step still pushes the branch, then ends as skipped with a plain message. If the forge printed an "open a pull request" link on push (Gitea, Forgejo, GitLab and Bitbucket do), the message includes it, with any credentials removed.
• The run goes on: the pick is kept, the other attempts are archived, and the run succeeds.

A pull request that fails on GitHub no longer fails the run:

• The pr step opens a gate, "The pull request didn't open". It quotes gh's words and says the agents' work and the pick are kept.
• Retry publishing runs the step again. Finish without a pull request ends it as skipped and the run goes on. Both work through the existing decide API (berth run approve / berth run reject).
• The choice is journaled, so after a berthd restart the run asks the same question again instead of re-running gh.

Elsewhere:

• Gate gets approve_label and reject_label, so the buttons in the app and the CLI say what they do.
• /v1/review includes the pr step.
• Review's Compare and the runs timeline show the note and its two buttons.
• Credentials are stripped from URLs in push and gh output.

Gitea API pull requests: not added. The box has no Gitea credential (gh's token is GitHub-only), and tea can't be assumed to be installed. Pushing the branch and passing on the forge's own compare link is the safe step now.

Behaviour change: in your own flows, a pr step that fails now waits at the gate instead of failing the run. A step with when: "failure" after a pr step won't run, because choosing "Finish without a pull request" counts as skipped, not failed.

Proof

A pull request that didn't open (mock):

An attempts run on a Gitea repository, finished with its branch pushed:

The runs timeline:

Tests

The box tests use real git: a bare repository with a Gitea-style post-receive hook, and a fake gh that logs its calls.

--- PASS: TestThePRStepOnGiteaPushesAndSkips          # gh only asked "auth status --hostname gitea.acme.test"; branch pushed
--- PASS: TestThePRStepOnGitHubFailsWithGhsWords      # and the credential in the remote is stripped
--- PASS: TestThePRStepOpensOnASignedInEnterpriseHost
--- PASS: TestRemoteHostsAndPushLinks
--- PASS: TestAttemptsPRSkippedOnAnotherForgeStillCleansUp
--- PASS: TestAttemptsPRFailureWaitsThenRetries       # through a restart: gh isn't re-run, then the retry succeeds
--- PASS: TestAttemptsPRFailureFinishesWithoutOne

• app/e2e/publish-failed.spec.ts (3 tests) passes.
• typecheck, check:titles, check:csp, check:themes, pnpm test, build, tsc -p e2e, cargo check and the docs build pass.
• Locally TestAttachPassesShiftEnter fails against tmux 3.7c, the same way on a clean origin/main.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
berth	Ready	Preview	Oct 18, 2026 5:25pm UTC
berth-docs	Ready	Preview	Oct 18, 2026 5:25pm UTC

[linear-code]

ENG-6405

[daniil616]

thank you