Repository navigation
fix sorting in sort_by_label and sort_by_label_desc - #7886
Open
SungJin1212 wants to merge 1 commit into
Open
SungJin1212 wants to merge 1 commit into
SungJin1212 wants to merge 1 commit into
Conversation
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
fix-sort-by-label
branch
from
October 20, 2026 11:45
b6167fd to
9af3335
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When sharded instant query has
sort_by_labelorsort_by_label_desc, the query frontend re-sorts the merged result by sample value instead of by the given labels. For example, the result ofsort_by_label(sum by (job) (up), "job")comes back in value order rather thanjoborder.This PR adds a separate sort plan for them. It orders the merged series with Prometheus' own
sort_by_label/sort_by_label_descimplementation.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags